Re: Make some comdats implicitly hidden

2013-08-29 Thread Jan Hubicka
> On Thu, Aug 29, 2013 at 02:47:46PM +0200, Paolo Carlini wrote: > > On 08/29/2013 02:19 PM, Jan Hubicka wrote: > > >So my belief is that it is safe to drop those symbols from > > >libstdc++. Every program/DSO using them have to define its own > > >copy of those symbols, so I believe removing them

Re: Make some comdats implicitly hidden

2013-08-29 Thread Jakub Jelinek
On Thu, Aug 29, 2013 at 02:47:46PM +0200, Paolo Carlini wrote: > On 08/29/2013 02:19 PM, Jan Hubicka wrote: > >So my belief is that it is safe to drop those symbols from > >libstdc++. Every program/DSO using them have to define its own > >copy of those symbols, so I believe removing them from libst

Re: Make some comdats implicitly hidden

2013-08-29 Thread Jan Hubicka
> Hi, > > On 08/29/2013 02:19 PM, Jan Hubicka wrote: > >So my belief is that it is safe to drop those symbols from > >libstdc++. Every program/DSO using them have to define its own > >copy of those symbols, so I believe removing them from libstdc++ > >won't cause issues. > Really, you should check

Re: Make some comdats implicitly hidden

2013-08-29 Thread Paolo Carlini
Hi, On 08/29/2013 02:19 PM, Jan Hubicka wrote: So my belief is that it is safe to drop those symbols from libstdc++. Every program/DSO using them have to define its own copy of those symbols, so I believe removing them from libstdc++ won't cause issues. Really, you should check with Jakub befor

Re: Make some comdats implicitly hidden

2013-08-29 Thread Jan Hubicka
M > Hi, > > On 08/29/2013 10:11 AM, Jan Hubicka wrote: > >Paolo, > >there seems to be one extra issue about this patch. It causes quite a twist > >in libstdc++ exported symbols. > >It is purpose of the patch to remove those that are going to be generated in > >user programs, too. > >I am however

Re: Make some comdats implicitly hidden

2013-08-29 Thread Paolo Carlini
Hi, On 08/29/2013 10:11 AM, Jan Hubicka wrote: Paolo, there seems to be one extra issue about this patch. It causes quite a twist in libstdc++ exported symbols. It is purpose of the patch to remove those that are going to be generated in user programs, too. I am however bit confused about bad

Re: Make some comdats implicitly hidden

2013-08-29 Thread Jan Hubicka
Paolo, there seems to be one extra issue about this patch. It causes quite a twist in libstdc++ exported symbols. It is purpose of the patch to remove those that are going to be generated in user programs, too. I am however bit confused about bad array. Perhaps it is an optimization difference d

Re: Make some comdats implicitly hidden

2013-08-28 Thread Jason Merrill
Looks good. Jason

Re: Make some comdats implicitly hidden

2013-08-28 Thread Jan Hubicka
> On 08/26/2013 03:57 PM, Jan Hubicka wrote: > >While analyzing the relocations of libreoffice I noticed that I can play > >the same game w/o LTO at linker level. Making those symbols hidden truns > >external relocations to internal and should improve runtime, too: comdat > >sharing by dynamic lin

Re: Make some comdats implicitly hidden

2013-08-26 Thread Jason Merrill
On 08/26/2013 03:57 PM, Jan Hubicka wrote: While analyzing the relocations of libreoffice I noticed that I can play the same game w/o LTO at linker level. Making those symbols hidden truns external relocations to internal and should improve runtime, too: comdat sharing by dynamic linker is expen