Re: Improve handling of memory operands in ipa-icf 4/4

2020-11-20 Thread Martin Liška
On 11/19/20 11:14 AM, Jan Hubicka wrote: On 11/16/20 12:20 AM, Jan Hubicka wrote: This is controlled by -fipa-icf-alias-sets The patch drops too early, so we may end up processing function twice. Also if merging is not performed we lose code quality for no win (this is rare case). My original

Re: Improve handling of memory operands in ipa-icf 4/4

2020-11-19 Thread Jan Hubicka
> On 11/16/20 12:20 AM, Jan Hubicka wrote: > > This is controlled by -fipa-icf-alias-sets > > > > The patch drops too early, so we may end up processing function twice. > > Also if > > merging is not performed we lose code quality for no win (this is rare > > case). > > My original plan was to

Re: Improve handling of memory operands in ipa-icf 4/4

2020-11-18 Thread Martin Liška
On 11/16/20 12:20 AM, Jan Hubicka wrote: This is controlled by -fipa-icf-alias-sets The patch drops too early, so we may end up processing function twice. Also if merging is not performed we lose code quality for no win (this is rare case). My original plan was to remember the mismatched parame

Re: Improve handling of memory operands in ipa-icf 4/4

2020-11-16 Thread Richard Biener
On Mon, 16 Nov 2020, Jan Hubicka wrote: > Hi, > this patch implements the logic to drop base alias sets (and thus also access > paths) from memory operands when doing so helps merging. This is done > by extending func_checker::compare_operand to record mismatched pairs > and then processing this