Re: Implement -Wimplicit-fallthrough (take 2): fix missing breaks

2016-08-04 Thread Ian Lance Taylor
On Thu, Jul 28, 2016 at 8:57 AM, Marek Polacek wrote: > On Wed, Jul 27, 2016 at 10:05:25AM -0700, Mike Stump wrote: >> On Jul 27, 2016, at 9:52 AM, Marek Polacek wrote: >> > >> > This is what the new warning pointed out. I think all these are bugs. >> > >> > --- gcc/libgo/runtime/heapdump.c >> >

Re: Implement -Wimplicit-fallthrough (take 2): fix missing breaks

2016-08-01 Thread Richard Biener
On Fri, 29 Jul 2016, Marek Polacek wrote: > On Fri, Jul 29, 2016 at 01:46:11AM -0500, Segher Boessenkool wrote: > > On Thu, Jul 28, 2016 at 05:57:34PM +0200, Marek Polacek wrote: > > > Segher, is the rs6000.c part ok? > > > > Yes, that looks fine, thanks! Will you handle the backports as well? >

Re: Implement -Wimplicit-fallthrough (take 2): fix missing breaks

2016-07-29 Thread Marek Polacek
On Fri, Jul 29, 2016 at 02:14:01PM +0200, Uros Bizjak wrote: > Hello! > > > This is what the new warning pointed out. I think all these are bugs. > > > > This patch has been tested on powerpc64le-unknown-linux-gnu, > > aarch64-linux-gnu, > > and x86_64-redhat-linux. > > > > 2016-07-27 Marek Pol

Re: Implement -Wimplicit-fallthrough (take 2): fix missing breaks

2016-07-29 Thread Uros Bizjak
Hello! > This is what the new warning pointed out. I think all these are bugs. > > This patch has been tested on powerpc64le-unknown-linux-gnu, > aarch64-linux-gnu, > and x86_64-redhat-linux. > > 2016-07-27 Marek Polacek > > PR c/7652 > gcc/ > * config/i386/i386.c (ix86_expand_args_builtin):

Re: Implement -Wimplicit-fallthrough (take 2): fix missing breaks

2016-07-29 Thread Marek Polacek
On Fri, Jul 29, 2016 at 01:46:11AM -0500, Segher Boessenkool wrote: > On Thu, Jul 28, 2016 at 05:57:34PM +0200, Marek Polacek wrote: > > Segher, is the rs6000.c part ok? > > Yes, that looks fine, thanks! Will you handle the backports as well? Happy to, just not sure about 4.9. Richi, is it ok t

Re: Implement -Wimplicit-fallthrough (take 2): fix missing breaks

2016-07-28 Thread Segher Boessenkool
On Thu, Jul 28, 2016 at 05:57:34PM +0200, Marek Polacek wrote: > Segher, is the rs6000.c part ok? Yes, that looks fine, thanks! Will you handle the backports as well? Segher

Re: Implement -Wimplicit-fallthrough (take 2): fix missing breaks

2016-07-28 Thread Marek Polacek
On Wed, Jul 27, 2016 at 02:17:35PM -0600, Jeff Law wrote: > On 07/27/2016 10:52 AM, Marek Polacek wrote: > > This is what the new warning pointed out. I think all these are bugs. > > > > This patch has been tested on powerpc64le-unknown-linux-gnu, > > aarch64-linux-gnu, > > and x86_64-redhat-lin

Re: Implement -Wimplicit-fallthrough (take 2): fix missing breaks

2016-07-28 Thread Marek Polacek
On Wed, Jul 27, 2016 at 10:05:25AM -0700, Mike Stump wrote: > On Jul 27, 2016, at 9:52 AM, Marek Polacek wrote: > > > > This is what the new warning pointed out. I think all these are bugs. > > > > --- gcc/libgo/runtime/heapdump.c > > +++ gcc/libgo/runtime/heapdump.c > > @@ -766,6 +766,7 @@ dum

Re: Implement -Wimplicit-fallthrough (take 2): fix missing breaks

2016-07-28 Thread Marek Polacek
On Wed, Jul 27, 2016 at 11:43:22AM -0600, Tom Tromey wrote: > > "Marek" == Marek Polacek writes: > > Marek> gcc/java/ > Marek>* jcf-dump.c (print_constant): Add break. > > This bit is ok. Thanks Tom. I think I'll just commit this hunk separately to not post already approved bits ag

Re: Implement -Wimplicit-fallthrough (take 2): fix missing breaks

2016-07-27 Thread Jeff Law
On 07/27/2016 10:52 AM, Marek Polacek wrote: This is what the new warning pointed out. I think all these are bugs. This patch has been tested on powerpc64le-unknown-linux-gnu, aarch64-linux-gnu, and x86_64-redhat-linux. 2016-07-27 Marek Polacek PR c/7652 gcc/ * config/i386/

Re: Implement -Wimplicit-fallthrough (take 2): fix missing breaks

2016-07-27 Thread Tom Tromey
> "Marek" == Marek Polacek writes: Marek> gcc/java/ Marek> * jcf-dump.c (print_constant): Add break. This bit is ok. Tom

Re: Implement -Wimplicit-fallthrough (take 2): fix missing breaks

2016-07-27 Thread Mike Stump
On Jul 27, 2016, at 9:52 AM, Marek Polacek wrote: > > This is what the new warning pointed out. I think all these are bugs. > > --- gcc/libgo/runtime/heapdump.c > +++ gcc/libgo/runtime/heapdump.c > @@ -766,6 +766,7 @@ dumpefacetypes(void *obj __attribute__ ((unused)), > uintptr size, const Typ