Re: Hurd port for gcc go PATCH 1-4(23)

2016-12-18 Thread Samuel Thibault
Samuel Thibault, on Mon 19 Dec 2016 00:25:35 +0100, wrote: > as the attached patch does, which should really be applied or done > any other way. Or rather this patch, which makes it more like the test above. Matthias, I'm committing this to Debian's gcc-6, along the other go patches from Svante.

Re: Hurd port for gcc go PATCH 1-4(23)

2016-12-18 Thread Samuel Thibault
Hello, Svante Signell, on Fri 25 Nov 2016 20:57:26 +0100, wrote: > Another more annoying gnumch/hurd/glibc bug is that the > built program go (go-6 in Debian) gets killed when executed from the > shell vi path, but not when issued directly: /usr/bin/go-6 works fine. >  go-6 > Segmentation fault (c

Re: Hurd port for gcc go PATCH 1-4(23)

2016-12-07 Thread Ian Lance Taylor
On Wed, Dec 7, 2016 at 2:02 PM, Svante Signell wrote: > > I'm sorry but neither of you or I are in the position to request changes of > already existing file names e.g. replacing linux with glibc in: > os/pipe_linux.go > crypto/x509/root_linux.go > syscall/errstr_linux.go As you know, the name "l

Re: Hurd port for gcc go PATCH 1-4(23)

2016-12-07 Thread Svante Signell
On Wed, 2016-12-07 at 17:25 +0100, Samuel Thibault wrote: > Svante Signell, on Wed 07 Dec 2016 15:32:31 +0100, wrote: > > On Wed, 2016-12-07 at 15:08 +0100, Samuel Thibault wrote: > > > Ok, but then I'd say move the function which change to a separate file, > > > so that the other functions are kep

Re: Hurd port for gcc go PATCH 1-4(23)

2016-12-07 Thread Samuel Thibault
Svante Signell, on Wed 07 Dec 2016 15:32:31 +0100, wrote: > On Wed, 2016-12-07 at 15:08 +0100, Samuel Thibault wrote: > > Ok, but then I'd say move the function which change to a separate file, > > so that the other functions are kept shared. > > Otherwise it'll be tedious to maintain. > > One pro

Re: Hurd port for gcc go PATCH 1-4(23)

2016-12-07 Thread Svante Signell
On Wed, 2016-12-07 at 15:08 +0100, Samuel Thibault wrote: > Svante Signell, on Wed 07 Dec 2016 14:52:35 +0100, wrote: > > Since go does not have a preprocessor allowing conditional code paths this > > is > > how it should be done (and as I did): > > http://blog.ralch.com/tutorial/golang-conditional

Re: Hurd port for gcc go PATCH 1-4(23)

2016-12-07 Thread Samuel Thibault
Svante Signell, on Wed 07 Dec 2016 14:52:35 +0100, wrote: > Since go does not have a preprocessor allowing conditional code paths this is > how it should be done (and as I did): > http://blog.ralch.com/tutorial/golang-conditional-compilation/ Ok, but then I'd say move the function which change to

Re: Hurd port for gcc go PATCH 1-4(23)

2016-12-07 Thread Svante Signell
On Sun, 2016-11-27 at 18:02 +0100, Samuel Thibault wrote: > Hello, > > Svante Signell, on Sun 27 Nov 2016 17:33:52 +0100, wrote: > > > >  > > > And > > > src_libgo_go_syscall_syscall_gnu_test.go: New file: > > >   Define Type and Whence as 32bit in syscall.Flock_t > > > > > > Again, you'll probab

Re: Hurd port for gcc go PATCH 1-4(23)

2016-11-27 Thread Samuel Thibault
Svante Signell, on Sun 27 Nov 2016 18:17:17 +0100, wrote: > On Sun, 2016-11-27 at 18:02 +0100, Samuel Thibault wrote: > > > But as you wish, an updated patch is attached. > > > >  _Bool > >  Continued (uint32_t *w) > >  { > > +#ifndef WCONTINUED > > +  *w = 0; > > +  return 0; > > +#else > >    re

Re: Hurd port for gcc go PATCH 1-4(23)

2016-11-27 Thread Svante Signell
On Sun, 2016-11-27 at 18:02 +0100, Samuel Thibault wrote: > Hello, ... > > But as you wish, an updated patch is attached. > >  _Bool >  Continued (uint32_t *w) >  { > +#ifndef WCONTINUED > +  *w = 0; > +  return 0; > +#else >    return WIFCONTINUED (*w) != 0; > +#endif >  } > > Err, recheck the s

Re: Hurd port for gcc go PATCH 1-4(23)

2016-11-27 Thread Samuel Thibault
Hello, Svante Signell, on Sun 27 Nov 2016 17:33:52 +0100, wrote: > > > Index: gcc-6-6.2.1-4.1/src/libgo/go/syscall/wait.c > > > === > > > --- gcc-6-6.2.1-4.1.orig/src/libgo/go/syscall/wait.c > > > +++ gcc-6-6.2.1-4.1/src/libgo/go/sysc

Re: Hurd port for gcc go PATCH 7-9 (9)

2014-05-06 Thread Samuel Thibault
Svante Signell, le Tue 06 May 2014 14:13:54 +0200, a écrit : > > > +# Special treatment of EWOULDBLOCK for GNU/Hurd > > > +# /usr/include/bits/errno.h: #define EWOULDBLOCK EAGAIN > > > +egrep '^const EWOULDBLOCK = Errno(_EWOULDBLOCK)' ${OUT} | \ > > > +sed -i.bak -e 's/_EWOULDBLOCK/_EAGAIN/' ${

Re: Hurd port for gcc go PATCH 7-9 (9)

2014-05-06 Thread Svante Signell
On Tue, 2014-05-06 at 11:07 +0200, Samuel Thibault wrote: > Svante Signell, le Tue 06 May 2014 10:58:38 +0200, a écrit : > > The patch for st_dev by Thomas Schwinge was not liked by Samuel > > Uh? > > I said “These should be fine, however.” and “a sed rule can't hurt even > if there is no occurre

Re: Hurd port for gcc go PATCH 7-9 (9)

2014-05-06 Thread Samuel Thibault
Svante Signell, le Tue 06 May 2014 10:58:38 +0200, a écrit : > The patch for st_dev by Thomas Schwinge was not liked by Samuel Uh? I said “These should be fine, however.” and “a sed rule can't hurt even if there is no occurrence...” So just keep that precise part back as it was, no need for bein

Re: Hurd port for gcc go PATCH 7-9 (9)

2014-04-14 Thread Svante Signell
On Mon, 2014-04-14 at 11:03 +0200, Samuel Thibault wrote: > Svante Signell, le Mon 14 Apr 2014 09:59:03 +0200, a écrit : > > > > @@ -528,6 +538,8 @@ > > > > > > > > # The stat type. > > > > # Prefer largefile variant if available. > > > > +# Special treatment of st_dev for GNU/Hurd > > > > +# /

Re: Hurd port for gcc go PATCH 7-9 (9)

2014-04-14 Thread Samuel Thibault
Svante Signell, le Mon 14 Apr 2014 09:59:03 +0200, a écrit : > > > @@ -528,6 +538,8 @@ > > > > > > # The stat type. > > > # Prefer largefile variant if available. > > > +# Special treatment of st_dev for GNU/Hurd > > > +# /usr/include/i386-gnu/bits/stat.h: #define st_dev st_fsid > > > stat=`gr

Re: Hurd port for gcc go PATCH 7-9 (9)

2014-04-14 Thread Svante Signell
On Fri, 2014-04-11 at 22:55 +0200, Samuel Thibault wrote: > Svante Signell, le Fri 11 Apr 2014 14:57:35 +0200, a écrit : > > --- a/src/libgo/mksysinfo.sh > > +++ b/src/libgo/mksysinfo.sh > > Err, these seem to get applied to all systems, not just GNU/Hurd, isn't > that a concern? > > > @@ -210,6

Re: Hurd port for gcc go PATCH 0-3 (9)

2014-04-14 Thread Svante Signell
On Fri, 2014-04-11 at 22:52 +0200, Samuel Thibault wrote: > Svante Signell, le Fri 11 Apr 2014 14:47:21 +0200, a écrit : > > #ifdef TARGET_LIBC_PROVIDES_SSP > > +/* i386 glibc provides __stack_chk_guard in %gs:0x14. */ > > +#define TARGET_THREAD_SSP_OFFSET 0x14 > > Err, not the Hurd variant, n

Re: Hurd port for gcc go PATCH 0-3 (9)

2014-04-12 Thread Ian Lance Taylor
On Sat, Apr 12, 2014 at 7:04 AM, Svante Signell wrote: > > (cd src/libgo;automake-1.11) > aclocal.m4:16: warning: this file was generated for autoconf 2.64. > You have another version of autoconf. It may work, but is not > guaranteed to. To rebuild any of the GCC configuration generated files, y

Re: Hurd port for gcc go PATCH 0-3 (9)

2014-04-12 Thread Svante Signell
On Sat, 2014-04-12 at 16:04 +0200, Svante Signell wrote: > On Fri, 2014-04-11 at 07:48 -0700, Ian Lance Taylor wrote: > > On Fri, Apr 11, 2014 at 5:47 AM, Svante Signell > > wrote: > > > > I don't understand this comment. The GCC libraries do still use > > automake. I regularly use automake to

Re: Hurd port for gcc go PATCH 0-3 (9)

2014-04-12 Thread Svante Signell
On Fri, 2014-04-11 at 07:48 -0700, Ian Lance Taylor wrote: > On Fri, Apr 11, 2014 at 5:47 AM, Svante Signell > wrote: > > > > Attached are patches to enable gccgo to build properly on Debian > > GNU/Hurd on gcc-4.9 (4.9-20140406). > > Thanks. Will review after 4.9 has branched. Thanks! Modified

Re: Hurd port for gcc go PATCH 0-3 (9)

2014-04-11 Thread Samuel Thibault
Svante Signell, le Fri 11 Apr 2014 14:47:21 +0200, a écrit : > #ifdef TARGET_LIBC_PROVIDES_SSP > +/* i386 glibc provides __stack_chk_guard in %gs:0x14. */ > +#define TARGET_THREAD_SSP_OFFSET 0x14 Err, not the Hurd variant, no. Is it really needed? > @@ -682,7 +686,7 @@ > go_net_cgo_file =

Re: Hurd port for gcc go PATCH 0-3 (9)

2014-04-11 Thread Ian Lance Taylor
On Fri, Apr 11, 2014 at 5:47 AM, Svante Signell wrote: > > Attached are patches to enable gccgo to build properly on Debian > GNU/Hurd on gcc-4.9 (4.9-20140406). Thanks. Will review after 4.9 has branched. > Note: Creating the Makefile.in is hard (unnecessary) work since automake > is no longer

Re: Hurd port for GCC Go

2013-06-26 Thread Thomas Schwinge
Hi! On Fri, 14 Jun 2013 16:42:06 +0200, I wrote: > I have now pushed my working branch to tschwinge/t/hurd/go, and will > update this from time to time, both for integrating further changes (my > own as well as those that you send me), and merge in GCC trunk changes. > On that branch, use somethin