Re: Handling of main() function for freestanding

2022-10-14 Thread Jason Merrill via Gcc-patches
On 10/14/22 06:04, Arsen Arsenović wrote: On Thursday, 13 October 2022 23:16:02 CEST Jason Merrill wrote: I liked in the previous version that you checked the return type of main when !flag_hosted, here and in c_missing_noreturn_ok_p. Let's bring that back. Ah, right; I forgot about that. Wha

Re: Handling of main() function for freestanding

2022-10-14 Thread Arsen Arsenović via Gcc-patches
On Thursday, 13 October 2022 23:16:02 CEST Jason Merrill wrote: > I liked in the previous version that you checked the return type of > main when !flag_hosted, here and in c_missing_noreturn_ok_p. Let's > bring that back. Ah, right; I forgot about that. What do you think of this? Thanks, -- A

Re: Handling of main() function for freestanding

2022-10-13 Thread Jason Merrill via Gcc-patches
On 10/13/22 16:14, Arsen Arsenović wrote: On Thursday, 13 October 2022 19:24:41 CEST Jason Merrill wrote: I was arguing that we don't need the new flag; there shouldn't be any need to turn it off. At the time, I opted to go with a more conservative route; I haven't been around enough to have ve

Re: Handling of main() function for freestanding

2022-10-13 Thread Arsen Arsenović via Gcc-patches
On Thursday, 13 October 2022 19:24:41 CEST Jason Merrill wrote: > I was arguing that we don't need the new flag; there shouldn't be any > need to turn it off. At the time, I opted to go with a more conservative route; I haven't been around enough to have very strong opinions ;) I certainly can't

Re: Handling of main() function for freestanding

2022-10-13 Thread Arsen Arsenović via Gcc-patches
On Thursday, 13 October 2022 19:10:10 CEST Jakub Jelinek wrote: > Don't we have such a test already elsewhere? If not, then certain > "warn for main" part should be removed or replaced... Whoops, missed that comment. There is actually an equivalent test that I overlooked (noreturn-1.c), so mayb

Re: Handling of main() function for freestanding

2022-10-13 Thread Jason Merrill via Gcc-patches
On 10/13/22 13:02, Arsen Arsenović wrote: Hi, On Friday, 7 October 2022 15:51:31 CEST Jason Merrill wrote: * gcc.dg/noreturn-4.c: Likewise. I'd be inclined to drop this test. That seems like an odd choice, why do that over using another function for the test case? (there's nothing sp

Re: Handling of main() function for freestanding

2022-10-13 Thread Jakub Jelinek via Gcc-patches
On Thu, Oct 13, 2022 at 07:03:24PM +0200, Arsen Arsenović wrote: > @@ -1,10 +1,10 @@ > /* Check for "noreturn" warning in main. */ > /* { dg-do compile } */ > -/* { dg-options "-O2 -Wmissing-noreturn -ffreestanding" } */ > +/* { dg-options "-O2 -Wmissing-noreturn" } */ > extern void exit (int) _

Re: Handling of main() function for freestanding

2022-10-13 Thread Arsen Arsenović via Gcc-patches
Hi, On Friday, 7 October 2022 15:51:31 CEST Jason Merrill wrote: > > * gcc.dg/noreturn-4.c: Likewise. > > I'd be inclined to drop this test. That seems like an odd choice, why do that over using another function for the test case? (there's nothing specific to main in this test, and it doesn