Re: [gofrontend-dev] Re: Go patch committed: Fix error reporting for invalid builtin calls

2015-08-03 Thread Ian Lance Taylor
On Mon, Aug 3, 2015 at 7:24 PM, Michael Hudson-Doyle wrote: > > Now I get > > ../../../gcc/libgo/runtime/mprof.goc: In function ‘runtime_Stack’: > ../../../gcc/libgo/runtime/mprof.goc:437:19: error: ‘enablegc’ may be > used uninitialized in this function [-Werror=maybe-uninitialized] >mstats.e

Re: [gofrontend-dev] Re: Go patch committed: Fix error reporting for invalid builtin calls

2015-08-03 Thread Michael Hudson-Doyle
Now I get ../../../gcc/libgo/runtime/mprof.goc: In function ‘runtime_Stack’: ../../../gcc/libgo/runtime/mprof.goc:437:19: error: ‘enablegc’ may be used uninitialized in this function [-Werror=maybe-uninitialized] mstats.enablegc = enablegc; ^ ../../../gcc/libgo/runtime/mprof.

Re: Go patch committed: Fix error reporting for invalid builtin calls

2015-08-03 Thread Ian Lance Taylor
On Mon, Aug 3, 2015 at 2:10 AM, Andreas Schwab wrote: > ../../../libgo/runtime/mprof.goc: In function 'runtime_Stack': > ../../../libgo/runtime/mprof.goc:408:5: error: calling > '__builtin_frame_address' with a nonzero argument is unsafe > [-Werror=frame-address] > sp = runtime_getcallersp(&b

Re: Go patch committed: Fix error reporting for invalid builtin calls

2015-08-03 Thread Richard Biener
On Mon, Aug 3, 2015 at 11:10 AM, Andreas Schwab wrote: > Ian Lance Taylor writes: > >> This patch from Chris Manghane fixes the Go frontend error reporting >> for invalid builtin calls, by not losing track of whether the call is >> erroneous. This fixes https://golang.org/issue/11561. Bootstrap

Re: Go patch committed: Fix error reporting for invalid builtin calls

2015-08-03 Thread Andreas Schwab
Ian Lance Taylor writes: > This patch from Chris Manghane fixes the Go frontend error reporting > for invalid builtin calls, by not losing track of whether the call is > erroneous. This fixes https://golang.org/issue/11561. Bootstrapped > and ran Go testsuite on x86_64-unknown-linux-gnu. Commi