Re: GCC 11.1 Release Candidate available from gcc.gnu.org

2021-04-22 Thread Jakub Jelinek via Gcc-patches
On Thu, Apr 22, 2021 at 01:27:40PM +0100, Jonathan Wakely wrote: > I'm just finishing testing this on various targets and will push to > trunk. I'd like to backport it to gcc-11 too, to fix PR100179. Ok for 11.1. > commit 50070d8602a07160cece5890899929e9f210244d > Author: Jonathan Wakely > Date:

Re: GCC 11.1 Release Candidate available from gcc.gnu.org

2021-04-22 Thread Jonathan Wakely via Gcc-patches
On 21/04/21 15:30 +0100, Jonathan Wakely wrote: On 21/04/21 13:12 +0100, Jonathan Wakely wrote: On 21/04/21 12:38 +0100, Jonathan Wakely wrote: On 20/04/21 22:12 -0700, Thomas Rodgers wrote: @@ -86,6 +88,24 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION } } +_GLIBCXX_ALWAYS_INLINE bool +

Re: GCC 11.1 Release Candidate available from gcc.gnu.org

2021-04-21 Thread Jonathan Wakely via Gcc-patches
On 21/04/21 13:12 +0100, Jonathan Wakely wrote: On 21/04/21 12:38 +0100, Jonathan Wakely wrote: On 20/04/21 22:12 -0700, Thomas Rodgers wrote: @@ -86,6 +88,24 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION } } +_GLIBCXX_ALWAYS_INLINE bool +_M_try_acquire() noexcept +{ + for (;;

Re: GCC 11.1 Release Candidate available from gcc.gnu.org

2021-04-21 Thread David Edelsohn via Gcc-patches
Hi, Jonathan Thanks for the further investigation. I definitely encountered the missing _M_try_acquire in __platform_semaphore. Thanks, David On Wed, Apr 21, 2021 at 8:12 AM Jonathan Wakely wrote: > > On 21/04/21 12:38 +0100, Jonathan Wakely wrote: > >On 20/04/21 22:12 -0700, Thomas Rodgers wr

Re: GCC 11.1 Release Candidate available from gcc.gnu.org

2021-04-21 Thread Thomas Rodgers
On 2021-04-21 05:12, Jonathan Wakely wrote: On 21/04/21 12:38 +0100, Jonathan Wakely wrote: On 20/04/21 22:12 -0700, Thomas Rodgers wrote: @@ -86,6 +88,24 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION } } +_GLIBCXX_ALWAYS_INLINE bool +_M_try_acquire() noexcept +{ + for (;;) +{ +

Re: GCC 11.1 Release Candidate available from gcc.gnu.org

2021-04-21 Thread Jonathan Wakely via Gcc-patches
On 21/04/21 12:38 +0100, Jonathan Wakely wrote: On 20/04/21 22:12 -0700, Thomas Rodgers wrote: @@ -86,6 +88,24 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION } } +_GLIBCXX_ALWAYS_INLINE bool +_M_try_acquire() noexcept +{ + for (;;) + { + auto __err = sem_trywait(&

Re: GCC 11.1 Release Candidate available from gcc.gnu.org

2021-04-21 Thread Jonathan Wakely via Gcc-patches
On 20/04/21 22:12 -0700, Thomas Rodgers wrote: @@ -86,6 +88,24 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION } } +_GLIBCXX_ALWAYS_INLINE bool +_M_try_acquire() noexcept +{ + for (;;) + { + auto __err = sem_trywait(&_M_semaphore); + if (__err && (errno ==

Re: GCC 11.1 Release Candidate available from gcc.gnu.org

2021-04-21 Thread Jonathan Wakely via Gcc-patches
On 21/04/21 10:56 +0200, Jakub Jelinek via Libstdc++ wrote: On Tue, Apr 20, 2021 at 10:12:33PM -0700, Thomas Rodgers wrote: I think the attached patch (also in BZ) addresses the issue in bits/semaphore_base.h, but I'm going to defer to Jonathan on why the macro name is being transformed incorrec

Re: GCC 11.1 Release Candidate available from gcc.gnu.org

2021-04-21 Thread Jakub Jelinek via Gcc-patches
On Tue, Apr 20, 2021 at 10:12:33PM -0700, Thomas Rodgers wrote: > I think the attached patch (also in BZ) addresses the issue in > bits/semaphore_base.h, but I'm going to defer to Jonathan on why the macro > name is being transformed incorrectly in the first place. Jonathan's call, but for me it l