Re: Fix warnings in build with G++

2011-07-12 Thread Richard Kenner
> > FWIW, elsewhere in gcc we use "continue;" for empty loop bodies. > > I think I've never run into this idiom in about a decade of work on GCC. :-) Nor have I. I'm used to seeing just a ";" on its own line.

Re: Fix warnings in build with G++

2011-07-12 Thread Eric Botcazou
> FWIW, elsewhere in gcc we use "continue;" for empty loop bodies. I think I've never run into this idiom in about a decade of work on GCC. :-) Sometimes there is a comment after the ; on the line, but this is somewhat redundant IMO. Maybe we should simply ban loops with emtpy bodies. -- Eric

Re: Fix warnings in build with G++

2011-07-12 Thread Richard Henderson
On 07/12/2011 01:07 PM, Eric Botcazou wrote: > - while (*constraint++ != ','); > + while (*constraint++ != ',') > + ; FWIW, elsewhere in gcc we use "continue;" for empty loop bodies. r~