Re: Fix flags for edges from/to entry/exit basic blocks (issue5486043)

2011-12-14 Thread Dmitry Vyukov
On Wed, Dec 14, 2011 at 9:25 AM, Hans-Peter Nilsson wrote: >> From: Dmitry Vyukov >> Date: Tue, 13 Dec 2011 11:43:18 +0100 > >> On Tue, Dec 13, 2011 at 3:04 AM, Hans-Peter Nilsson >> wrote: >> > Details in PR51521. >> Sorry for the trouble. What should I do now? > > Do what Diego and others aske

Re: Fix flags for edges from/to entry/exit basic blocks (issue5486043)

2011-12-13 Thread Hans-Peter Nilsson
> From: Dmitry Vyukov > Date: Tue, 13 Dec 2011 11:43:18 +0100 > On Tue, Dec 13, 2011 at 3:04 AM, Hans-Peter Nilsson > wrote: > > Details in PR51521. > Sorry for the trouble. What should I do now? Do what Diego and others asked, roll back your patch immediately; I see it hasn't happened yet. No

Re: Fix flags for edges from/to entry/exit basic blocks (issue5486043)

2011-12-13 Thread Diego Novillo
On 11-12-13 09:22 , Diego Novillo wrote: When testing the patch, you should just run 'make -jN -k check' from the toplevel build directory, do not just test a subset of the testsuite. Additionally, you will need to configure and build with all the default languages. Your change affects every

Re: Fix flags for edges from/to entry/exit basic blocks (issue5486043)

2011-12-13 Thread Diego Novillo
On Tue, Dec 13, 2011 at 05:43, Dmitry Vyukov wrote: > Sorry for the trouble. What should I do now? > Just in case I've prepared a patch that rolls it back: > http://codereview.appspot.com/5485054 Dmitry, please roll back the patch for now. You should be able to see the failures if you run full

Re: Fix flags for edges from/to entry/exit basic blocks (issue5486043)

2011-12-13 Thread Dmitry Vyukov
On Tue, Dec 13, 2011 at 3:04 AM, Hans-Peter Nilsson wrote: > > (Please don't forget to CC gcc-patches on replies.  Thanks.) > > > From: Dmitriy Vyukov > > Date: Mon, 12 Dec 2011 14:43:10 +0100 > > > Fix flags for edges from/to entry/exit basic blocks. > > W/o this patch I hit internal asserts whe

Re: Fix flags for edges from/to entry/exit basic blocks (issue5486043)

2011-12-12 Thread Andrew Pinski
On Mon, Dec 12, 2011 at 3:04 PM, Hans-Peter Nilsson wrote: > (Please don't forget to CC gcc-patches on replies.  Thanks.) > >> From: Dmitriy Vyukov >> Date: Mon, 12 Dec 2011 14:43:10 +0100 > >> Fix flags for edges from/to entry/exit basic blocks. >> W/o this patch I hit internal asserts when tryi

Re: Fix flags for edges from/to entry/exit basic blocks (issue5486043)

2011-12-12 Thread Hans-Peter Nilsson
(Please don't forget to CC gcc-patches on replies. Thanks.) > From: Dmitriy Vyukov > Date: Mon, 12 Dec 2011 14:43:10 +0100 > Fix flags for edges from/to entry/exit basic blocks. > W/o this patch I hit internal asserts when trying to > split the edge from entry block. > > Index: gcc/cgraphunit.

Re: Fix flags for edges from/to entry/exit basic blocks (issue5486043)

2011-12-12 Thread Diego Novillo
On Mon, Dec 12, 2011 at 08:43, Dmitriy Vyukov wrote: > Fix flags for edges from/to entry/exit basic blocks. > W/o this patch I hit internal asserts when trying to > split the edge from entry block. Please specify how you tested it (http://gcc.gnu.org/contribute.html#testing). OK for trunk, if te