Re: Fix PR37916 (compile time regression)

2018-11-20 Thread Richard Biener
On Tue, Nov 20, 2018 at 3:19 PM Michael Matz wrote: > > Hi, > > On Tue, 20 Nov 2018, Richard Biener wrote: > > > > Anyway, regstrapped on x86-64-linux, no regressions. Okay for trunk? > > > > Ick. Given you do that only for one stmt kind and it looks kind of ugly > > wouldn't it be better to spl

Re: Fix PR37916 (compile time regression)

2018-11-20 Thread Michael Matz
Hi, On Tue, 20 Nov 2018, Richard Biener wrote: > > Anyway, regstrapped on x86-64-linux, no regressions. Okay for trunk? > > Ick. Given you do that only for one stmt kind and it looks kind of ugly > wouldn't it be better to splat out gimple_set_location (g, > input_location) to all 108 places

Re: Fix PR37916 (compile time regression)

2018-11-20 Thread Richard Biener
On Tue, Nov 20, 2018 at 2:23 PM Michael Matz wrote: > > Hi, > > the testcase gcc.dg/20020425-1.c was once a compile time hog. With > current trunk it only needs 7 seconds (on my machine, with -O0 cc1) but > there's still something to improve as virtually all of that time is > wasted in repeatedly