> 2013-05-19 Easwaran Raman
>
> PR tree-optimization/57322
> * (build_and_add_sum): If a BB is empty, set the UID of the
> statement added to the BB to be 1.
Missing filename in the ChangeLog.
--
Eric Botcazou
On Mon, May 20, 2013 at 4:04 PM, Steven Bosscher wrote:
> On Mon, May 20, 2013 at 4:00 PM, Easwaran Raman wrote:
>> If your suggestion is to use that
>> instead of 1 when BB == NULL, that would work (even though setting it
>> to 1 is sufficient.)
>
> That's what I suggest, yes. I understand that 1
On Mon, May 20, 2013 at 4:00 PM, Easwaran Raman wrote:
> If your suggestion is to use that
> instead of 1 when BB == NULL, that would work (even though setting it
> to 1 is sufficient.)
That's what I suggest, yes. I understand that 1 is sufficient for now,
but you never know if/when someone will u
If you are suggesting using inc_gimple_stmt_max_uid(cfun) for all
statements, that won't work because we want to use the UIDs to
determine dominance within a BB. If your suggestion is to use that
instead of 1 when BB == NULL, that would work (even though setting it
to 1 is sufficient.)
Thanks,
Eas
On Mon, May 20, 2013 at 1:41 AM, Easwaran Raman wrote:
> PR tree-optimization/57322
> * (build_and_add_sum): If a BB is empty, set the UID of the statement
> added to the BB to be 1.
Maybe "gimple_set_uid (stmt, inc_gimple_stmt_max_uid (cfun));"? That
would keep the UIDs
2013/5/20 Easwaran Raman :
> The UID of a newly generated statement in build_and_add_sum is set to
> that of an adjacent statement in the BB. This is a problem in one case
> where the BB is empty. This fix sets the UID to be 1 if the BB is
> empty. Bootstraps and no test regressions on x86_64 . OK
