Re: Fix PR 67609

2015-11-26 Thread Richard Henderson
On 11/25/2015 06:14 PM, James Greenhalgh wrote: On Tue, Oct 27, 2015 at 01:21:51PM -0700, Richard Henderson wrote: * aarch64 is almost certainly vulnerable, since it deleted its CANNOT_CHANGE_MODE_CLASS implementation in January. I haven't tried to create a test case that fails for it, but I

Re: Fix PR 67609

2015-11-25 Thread James Greenhalgh
On Tue, Oct 27, 2015 at 01:21:51PM -0700, Richard Henderson wrote: > The problem in this PR is that a word-mode subreg is used to write to a > multi-word pseudo, under the assumption that is the correct way to insert a > value into the appropriate bits of the pseudo. > > Except that the pseudo the

Re: Fix PR 67609

2015-10-27 Thread H.J. Lu
On Tue, Oct 27, 2015 at 4:45 PM, H.J. Lu wrote: > On Tue, Oct 27, 2015 at 1:21 PM, Richard Henderson wrote: >> The problem in this PR is that a word-mode subreg is used to write to a >> multi-word pseudo, under the assumption that is the correct way to insert a >> value into the appropriate bits

Re: Fix PR 67609

2015-10-27 Thread H.J. Lu
On Tue, Oct 27, 2015 at 1:21 PM, Richard Henderson wrote: > The problem in this PR is that a word-mode subreg is used to write to a > multi-word pseudo, under the assumption that is the correct way to insert a > value into the appropriate bits of the pseudo. > > Except that the pseudo then gets as