Re: Fix MEM_REF creation for shared stack slots

2019-05-22 Thread Richard Biener
On Tue, 21 May 2019, Richard Biener wrote: > And that should be done at RTL creation time instead of > repeatedly over and over. Like with the following. > > Bootstrap / regtest on x86_64-unknown-linux-gnu in progress. But we can't get away w/o unsharing the expr we change so committed as follo

Re: Fix MEM_REF creation for shared stack slots

2019-05-21 Thread Richard Biener
On May 21, 2019 5:17:43 PM GMT+02:00, Jeff Law wrote: >On 5/21/19 8:37 AM, Jan Hubicka wrote: >>> And that should be done at RTL creation time instead of >>> repeatedly over and over. Like with the following. >>> >>> Bootstrap / regtest on x86_64-unknown-linux-gnu in progress. >> >> Thanks, >> f

Re: Fix MEM_REF creation for shared stack slots

2019-05-21 Thread Jeff Law
On 5/21/19 8:37 AM, Jan Hubicka wrote: >> And that should be done at RTL creation time instead of >> repeatedly over and over. Like with the following. >> >> Bootstrap / regtest on x86_64-unknown-linux-gnu in progress. > > Thanks, > for TBAA stats I now get > > Alias oracle query stats: > refs

Re: Fix MEM_REF creation for shared stack slots

2019-05-21 Thread Jan Hubicka
> And that should be done at RTL creation time instead of > repeatedly over and over. Like with the following. > > Bootstrap / regtest on x86_64-unknown-linux-gnu in progress. Thanks, for TBAA stats I now get Alias oracle query stats: refs_may_alias_p: 3022975 disambiguations, 3321454 queries

Re: Fix MEM_REF creation for shared stack slots

2019-05-21 Thread Richard Biener
On Tue, 21 May 2019, Richard Biener wrote: > On Tue, 21 May 2019, Jan Hubicka wrote: > > > > > So about 8times of aliasing_component_refs hitrate. > > > > > > OK, one issue with the patch is that it restores TBAA for the > > > access which we may _not_ do IIRC. > > > > I can see that with stack

Re: Fix MEM_REF creation for shared stack slots

2019-05-21 Thread Richard Biener
On Tue, 21 May 2019, Jan Hubicka wrote: > > > So about 8times of aliasing_component_refs hitrate. > > > > OK, one issue with the patch is that it restores TBAA for the > > access which we may _not_ do IIRC. > > I can see that with stack sharing we have one memory location that for a > while is o

Re: Fix MEM_REF creation for shared stack slots

2019-05-21 Thread Jan Hubicka
> > So about 8times of aliasing_component_refs hitrate. > > OK, one issue with the patch is that it restores TBAA for the > access which we may _not_ do IIRC. I can see that with stack sharing we have one memory location that for a while is of type A and later is rewritten by type B, but we alrea

Re: Fix MEM_REF creation for shared stack slots

2019-05-21 Thread Richard Biener
On Tue, 21 May 2019, Jan Hubicka wrote: > Hi, > while creating shared stack slots we create a fake void * pointer and > merge the corresponidng points-to sets. Later ao_ref_from_mem constructs > mem_ref to feed alias oracle from. Since pointer is void we then > dereference it and keep with void_t