Re: FDO usability -- sanity check indirect call target

2011-04-11 Thread Richard Guenther
On Fri, Apr 8, 2011 at 11:42 PM, Xinliang David Li wrote: > Please review this patch. Regression test is ok. I will do more > application testing to make sure the check is not too strict > (filtering out legal ic targets). This one is ok. Thanks, Richard. > Thanks, > > David > > 2011-04-07  Xin

Re: FDO usability -- sanity check indirect call target

2011-04-10 Thread Xinliang David Li
Is this patch OK? Thanks, David On Sat, Apr 9, 2011 at 9:34 AM, Xinliang David Li wrote: > SPEC06 build with FDO is ok with the patch -- no abnormality was found. > > David > > On Fri, Apr 8, 2011 at 2:42 PM, Xinliang David Li wrote: >> Please review this patch. Regression test is ok. I will d

Re: FDO usability -- sanity check indirect call target

2011-04-09 Thread Xinliang David Li
SPEC06 build with FDO is ok with the patch -- no abnormality was found. David On Fri, Apr 8, 2011 at 2:42 PM, Xinliang David Li wrote: > Please review this patch. Regression test is ok. I will do more > application testing to make sure the check is not too strict > (filtering out legal ic target

Re: FDO usability -- sanity check indirect call target

2011-04-08 Thread Xinliang David Li
Please review this patch. Regression test is ok. I will do more application testing to make sure the check is not too strict (filtering out legal ic targets). Thanks, David 2011-04-07 Xinliang David Li * value-profile.c (function_decl_num_args): New function. (check_ic_target

Re: FDO usability -- sanity check indirect call target

2011-04-08 Thread Richard Guenther
On Fri, Apr 8, 2011 at 8:06 AM, Xinliang David Li wrote: > Hi, due to race conditions, it is common that the value profile > information for an indirect call site is 'corrupted' -- resulting in > false target function to be recorded. The value profile transformation > won't cause runtime problem a