On Mon, Nov 7, 2011 at 1:30 PM, Sharad Singhai wrote:
> Honza,
> Sorry, I forgot about this. Could you please put this on your TODO list?
>
> David,
> While a proper fix is pending for the trunk, we need this interim fix
> internally. Okay for google/main?
ok.
thanks,
David
>
> Thanks,
> Sharad
Honza,
Sorry, I forgot about this. Could you please put this on your TODO list?
David,
While a proper fix is pending for the trunk, we need this interim fix
internally. Okay for google/main?
Thanks,
Sharad
On Sun, Oct 2, 2011 at 3:08 AM, Jan Hubicka wrote:
>>
>> I believe Richi opent PR back wh
>
> I believe Richi opent PR back when he introduced the SSA profiling, but I
> don;t seem
> to be able to find it now.
Ha, you found it. It is PR gcov-profile/45890.
Given outcome of this dicussion I think it would make most sense to make
coverage just after into-SSA
(and perhaps arrange cfgcl
>
> Early inline can be important for FDO performance reasons -- as inline
> instances get 'context' sensitive profile data.
Yep, early inlining combine well with FDO.
> > Inlining alone does not mess up the line info, but most
> > optimizations we have in early optimization queue do.
>
> Inlin
I have updated PR/45890 with a test case.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45890
In any case, I am attaching a test case here as well.
Sharad
On Sat, Oct 1, 2011 at 10:19 AM, Xinliang David Li wrote:
>
> On Sat, Oct 1, 2011 at 5:17 AM, Jan Hubicka wrote:
> >> Yes, this will improve
On Sat, Oct 1, 2011 at 5:17 AM, Jan Hubicka wrote:
>> Yes, this will improve test coverage option's usability, but please
>> provide the example to explain the issues.
>>
>> David
>>
>> On Fri, Sep 30, 2011 at 6:12 PM, Sharad Singhai wrote:
>> > This patch disables early inlining when --coverage
> Yes, this will improve test coverage option's usability, but please
> provide the example to explain the issues.
>
> David
>
> On Fri, Sep 30, 2011 at 6:12 PM, Sharad Singhai wrote:
> > This patch disables early inlining when --coverage option is
> > specified. This improves coverage data in p
Here is an example. In the attached file, foo.c contains only two
functions, 'sum' and 'main'. The function 'sum' gets inlined into
'main' (with -O2).
gcc --coverage -O2 foo.c
./a.out
gcov -b foo.c
Now the coverage data for the 'if' condition in 'sum' looks like this:
(in attached file foo.c.gcov
Yes, this will improve test coverage option's usability, but please
provide the example to explain the issues.
David
On Fri, Sep 30, 2011 at 6:12 PM, Sharad Singhai wrote:
> This patch disables early inlining when --coverage option is
> specified. This improves coverage data in presence of other
