Re: Deque rotate on current node

2020-09-02 Thread François Dumont via Gcc-patches
On 01/09/20 3:25 pm, Jonathan Wakely wrote: On 01/09/20 14:06 +0200, François Dumont wrote: Hi No chance to review this small patch ? I did review it, and I wasn't convinced it was a good change. It only helps a particular usage pattern, and might hurt in other cases.     I shouldn't have

Re: Deque rotate on current node

2020-09-01 Thread Jonathan Wakely via Gcc-patches
On 01/09/20 14:06 +0200, François Dumont wrote: Hi No chance to review this small patch ? I did review it, and I wasn't convinced it was a good change. It only helps a particular usage pattern, and might hurt in other cases. I don't agree with your assertion that you use std::deque when you

Re: Deque rotate on current node

2020-09-01 Thread François Dumont via Gcc-patches
Hi No chance to review this small patch ? François On 30/06/20 10:33 pm, François Dumont wrote: Hi Any feedback regarding this patch ? François On 17/01/20 6:27 pm, François Dumont wrote: On 1/17/20 11:01 AM, Jonathan Wakely wrote: On 20/05/19 07:39 +0200, François Dumont wrote: Hi  

Re: Deque rotate on current node

2020-06-30 Thread François Dumont via Gcc-patches
Hi Any feedback regarding this patch ? François On 17/01/20 6:27 pm, François Dumont wrote: On 1/17/20 11:01 AM, Jonathan Wakely wrote: On 20/05/19 07:39 +0200, François Dumont wrote: Hi   std::deque is supposed to be like a double-queue that you can attack from front and back. But currre

Re: Deque rotate on current node

2020-01-17 Thread François Dumont
On 1/17/20 11:01 AM, Jonathan Wakely wrote: On 20/05/19 07:39 +0200, François Dumont wrote: Hi   std::deque is supposed to be like a double-queue that you can attack from front and back. But currrently its implementation makes it behave differently when starting from a fresh deque. If push_ba

Re: Deque rotate on current node

2020-01-17 Thread Jonathan Wakely
On 20/05/19 07:39 +0200, François Dumont wrote: Hi   std::deque is supposed to be like a double-queue that you can attack from front and back. But currrently its implementation makes it behave differently when starting from a fresh deque. If push_back then all goes well, it is copy/move to th

Re: Deque rotate on current node

2020-01-16 Thread François Dumont
After the recent optimization that went in despite in stage 4 I wonder why I never got any feedback for this one. https://gcc.gnu.org/ml/libstdc++/2019-05/msg00166.html I forgot to note that this is the simplest reply to an old Paolo's request to recycle std::deque's "nodes". And this one is a