Re: Concepts code review

2014-11-16 Thread Andrew Sutton
>>> +// Bring the parameters of a function declaration back into >>> +// scope without entering the function body. The declarator >>> +// must be a function declarator. The caller is responsible >>> +// for calling finish_scope. >>> +void >>> +push_function_parms (cp_declarator *declarator) >> >> I

Re: Concepts code review

2014-11-15 Thread Jason Merrill
On 11/15/2014 07:58 PM, Braden Obrzut wrote: Variable templates (and thus concepts) are TEMPLATE_ID_EXPR. I changed the comment to explicitly state that it will be a TEMPLATE_ID_EXPR, but I'm not sure the name needs to be changed. If I recall correctly, I initially implemented as *_var_concept

Re: Concepts code review

2014-11-15 Thread Braden Obrzut
I don't believe I'll be able to familiarize myself adequately with the more complex issues before the stage 1 deadline (from what I understand Andrew is/was taking care of the blocking issues?), so I will leave what I have for the more trivial issues and a few comments. On 11/11/2014 12:05 PM,

Re: Concepts code review

2014-11-13 Thread Jason Merrill
On 11/12/2014 06:11 PM, Andrew Sutton wrote: Agreed. I'll probably start looking at this on Friday morning. Note that end of stage 1 is Saturday, as I just realized today. So the sooner the better. :) Ouch. Good thing my merge with trunk broke in unexpected ways this morning -- minimally,

Re: Concepts code review

2014-11-12 Thread Andrew Sutton
>> Agreed. I'll probably start looking at this on Friday morning. > > > Note that end of stage 1 is Saturday, as I just realized today. So the > sooner the better. :) Ouch. Good thing my merge with trunk broke in unexpected ways this morning -- minimally, something in cgraph ended up missing a #

Re: Concepts code review

2014-11-12 Thread Jason Merrill
On 11/12/2014 10:27 AM, Andrew Sutton wrote: Agreed. I'll probably start looking at this on Friday morning. Note that end of stage 1 is Saturday, as I just realized today. So the sooner the better. :) deduce_concept_introduction (tree expr) Do you still need this coerce_template_parms

Re: Concepts code review

2014-11-12 Thread Andrew Sutton
>> + // The constraint info maintains information about constraints >> + // associated with the declaration. >> + tree constraint_info; > > > We talked back at the end of June about moving this into a separate > hashtable; I'm still reluctant to add another pointer to most declarations > when on