Re: Check that there are no missing probabilities

2017-10-17 Thread Jan Hubicka
> > graphite does > > if (changed) > { > cleanup_tree_cfg (); > profile_status_for_fn (cfun) = PROFILE_ABSENT; > release_recorded_exits (cfun); > tree_estimate_probability (false); > > so it runs into CFG cleanup running before it properly resets counts. > > I wond

Re: Check that there are no missing probabilities

2017-10-17 Thread Richard Biener
On Fri, Oct 13, 2017 at 9:27 PM, Jakub Jelinek wrote: > On Fri, Oct 13, 2017 at 09:06:55PM +0200, Jan Hubicka wrote: >> For EH we should set it to profile_probability::zero () because we know it >> is unlikely >> path. I will take a look. > > With the > > --- gcc/cfghooks.c.jj 2017-10-13 18:2

Re: Check that there are no missing probabilities

2017-10-13 Thread Andrew Pinski
On Fri, Oct 13, 2017 at 6:38 AM, Jan Hubicka wrote: > Hi, > this patch enables check that no edge probabilities are missing. This caused a bootstrap failure on aarch64-linux-gnu with go enabled. But I see you have disabled the code for now. Just for reference the failure: ../../../gcc/libgo/go/u

Re: Check that there are no missing probabilities

2017-10-13 Thread Jan Hubicka
> On Fri, Oct 13, 2017 at 09:06:55PM +0200, Jan Hubicka wrote: > > For EH we should set it to profile_probability::zero () because we know it > > is unlikely > > path. I will take a look. > > With the > > --- gcc/cfghooks.c.jj 2017-10-13 18:27:12.0 +0200 > +++ gcc/cfghooks.c2017-10

Re: Check that there are no missing probabilities

2017-10-13 Thread Jakub Jelinek
On Fri, Oct 13, 2017 at 09:06:55PM +0200, Jan Hubicka wrote: > For EH we should set it to profile_probability::zero () because we know it is > unlikely > path. I will take a look. With the --- gcc/cfghooks.c.jj 2017-10-13 18:27:12.0 +0200 +++ gcc/cfghooks.c 2017-10-13 19:15:11.4

Re: Check that there are no missing probabilities

2017-10-13 Thread Jan Hubicka
> On Fri, Oct 13, 2017 at 03:38:33PM +0200, Jan Hubicka wrote: > > Hi, > > this patch enables check that no edge probabilities are missing. > > > > Honza > > > > * cfghooks.c (verify_flow_info): Check that edge probabilities are > > set. > > This broke bootstrap on x86_64-linux with Ada

Re: Check that there are no missing probabilities

2017-10-13 Thread David Edelsohn
This patch also caused a huge number of testsuite failures on PowerPC, although it didn't break bootstrap. Thanks, David

Re: Check that there are no missing probabilities

2017-10-13 Thread Jakub Jelinek
On Fri, Oct 13, 2017 at 03:38:33PM +0200, Jan Hubicka wrote: > Hi, > this patch enables check that no edge probabilities are missing. > > Honza > > * cfghooks.c (verify_flow_info): Check that edge probabilities are > set. This broke bootstrap on x86_64-linux with Ada (--enable-check