Re: Change default level for -Wimplicit-fallthrough

2016-12-02 Thread Jeff Law
On 11/03/2016 05:51 AM, Bernd Schmidt wrote: I'm concerned about the number of false positives for this warning, and judging by previous discussions, I'm not alone in this. This patch limits it to level 1 (any comment before the case label disables the warning) for cases where the user specified

Re: Change default level for -Wimplicit-fallthrough

2016-11-03 Thread Markus Trippelsdorf
On 2016.11.03 at 14:57 +0100, Jakub Jelinek wrote: > On Thu, Nov 03, 2016 at 02:55:03PM +0100, Markus Trippelsdorf wrote: > > On 2016.11.03 at 14:47 +0100, Jakub Jelinek wrote: > > > On Thu, Nov 03, 2016 at 02:35:57PM +0100, Markus Trippelsdorf wrote: > > > > I don't have gathered detailed statisti

Re: Change default level for -Wimplicit-fallthrough

2016-11-03 Thread Jakub Jelinek
On Thu, Nov 03, 2016 at 02:55:03PM +0100, Markus Trippelsdorf wrote: > On 2016.11.03 at 14:47 +0100, Jakub Jelinek wrote: > > On Thu, Nov 03, 2016 at 02:35:57PM +0100, Markus Trippelsdorf wrote: > > > I don't have gathered detailed statistics. But for example a simple > > > /* drop through */ in a

Re: Change default level for -Wimplicit-fallthrough

2016-11-03 Thread Markus Trippelsdorf
On 2016.11.03 at 14:47 +0100, Jakub Jelinek wrote: > On Thu, Nov 03, 2016 at 02:35:57PM +0100, Markus Trippelsdorf wrote: > > I don't have gathered detailed statistics. But for example a simple > > /* drop through */ in a package header file will of course cause many > > bogus warnings during the b

Re: Change default level for -Wimplicit-fallthrough

2016-11-03 Thread Jakub Jelinek
On Thu, Nov 03, 2016 at 02:48:33PM +0100, Bernd Schmidt wrote: > > On 11/03/2016 02:47 PM, Jakub Jelinek wrote: > >On Thu, Nov 03, 2016 at 02:35:57PM +0100, Markus Trippelsdorf wrote: > >>I don't have gathered detailed statistics. But for example a simple > >>/* drop through */ in a package header

Re: Change default level for -Wimplicit-fallthrough

2016-11-03 Thread Bernd Schmidt
On 11/03/2016 02:47 PM, Jakub Jelinek wrote: On Thu, Nov 03, 2016 at 02:35:57PM +0100, Markus Trippelsdorf wrote: I don't have gathered detailed statistics. But for example a simple /* drop through */ in a package header file will of course cause many bogus warnings during the build on level 2.

Re: Change default level for -Wimplicit-fallthrough

2016-11-03 Thread Jakub Jelinek
On Thu, Nov 03, 2016 at 02:35:57PM +0100, Markus Trippelsdorf wrote: > I don't have gathered detailed statistics. But for example a simple > /* drop through */ in a package header file will of course cause many > bogus warnings during the build on level 2. > For the Linux kernel false positives dec

Re: Change default level for -Wimplicit-fallthrough

2016-11-03 Thread Markus Trippelsdorf
On 2016.11.03 at 14:24 +0100, Jakub Jelinek wrote: > On Thu, Nov 03, 2016 at 01:55:33PM +0100, Markus Trippelsdorf wrote: > > On 2016.11.03 at 13:32 +0100, Jakub Jelinek wrote: > > > On Thu, Nov 03, 2016 at 01:22:11PM +0100, Bernd Schmidt wrote: > > > > On 11/03/2016 12:58 PM, Jakub Jelinek wrote:

Re: Change default level for -Wimplicit-fallthrough

2016-11-03 Thread Jakub Jelinek
On Thu, Nov 03, 2016 at 01:55:33PM +0100, Markus Trippelsdorf wrote: > On 2016.11.03 at 13:32 +0100, Jakub Jelinek wrote: > > On Thu, Nov 03, 2016 at 01:22:11PM +0100, Bernd Schmidt wrote: > > > On 11/03/2016 12:58 PM, Jakub Jelinek wrote: > > > >On Thu, Nov 03, 2016 at 12:51:15PM +0100, Bernd Schm

Re: Change default level for -Wimplicit-fallthrough

2016-11-03 Thread Markus Trippelsdorf
On 2016.11.03 at 13:32 +0100, Jakub Jelinek wrote: > On Thu, Nov 03, 2016 at 01:22:11PM +0100, Bernd Schmidt wrote: > > On 11/03/2016 12:58 PM, Jakub Jelinek wrote: > > >On Thu, Nov 03, 2016 at 12:51:15PM +0100, Bernd Schmidt wrote: > > >>I'm concerned about the number of false positives for this w

Re: Change default level for -Wimplicit-fallthrough

2016-11-03 Thread Jakub Jelinek
On Thu, Nov 03, 2016 at 01:22:11PM +0100, Bernd Schmidt wrote: > On 11/03/2016 12:58 PM, Jakub Jelinek wrote: > >On Thu, Nov 03, 2016 at 12:51:15PM +0100, Bernd Schmidt wrote: > >>I'm concerned about the number of false positives for this warning, and > >>judging by previous discussions, I'm not al

Re: Change default level for -Wimplicit-fallthrough

2016-11-03 Thread Bernd Schmidt
On 11/03/2016 12:58 PM, Jakub Jelinek wrote: On Thu, Nov 03, 2016 at 12:51:15PM +0100, Bernd Schmidt wrote: I'm concerned about the number of false positives for this warning, and judging by previous discussions, I'm not alone in this. This patch limits it to level 1 (any comment before the case

Re: Change default level for -Wimplicit-fallthrough

2016-11-03 Thread Marek Polacek
On Thu, Nov 03, 2016 at 12:58:55PM +0100, Jakub Jelinek wrote: > On Thu, Nov 03, 2016 at 12:51:15PM +0100, Bernd Schmidt wrote: > > I'm concerned about the number of false positives for this warning, and > > judging by previous discussions, I'm not alone in this. This patch limits it > > to level 1

Re: Change default level for -Wimplicit-fallthrough

2016-11-03 Thread Jakub Jelinek
On Thu, Nov 03, 2016 at 12:51:15PM +0100, Bernd Schmidt wrote: > I'm concerned about the number of false positives for this warning, and > judging by previous discussions, I'm not alone in this. This patch limits it > to level 1 (any comment before the case label disables the warning) for > cases w