[committed] Re: C PATCH to kill c_save_expr or towards delayed folding for the C FE

2017-05-22 Thread Jakub Jelinek
Hi! On Fri, May 12, 2017 at 09:48:28PM +0200, Jakub Jelinek wrote: > On Fri, May 12, 2017 at 09:37:27PM +0200, Marek Polacek wrote: > > @@ -565,6 +564,25 @@ c_fully_fold_internal (tree expr, bool in_init, bool > > *maybe_const_operands, > > appropriate in any particular case. */ > >

Re: C PATCH to kill c_save_expr or towards delayed folding for the C FE

2017-05-15 Thread Joseph Myers
On Mon, 15 May 2017, Marek Polacek wrote: > Thanks for pointing this out! The new version: > > Bootstrapped/regtested on x86_64-linux. > > 2017-05-15 Marek Polacek > > * c-common.c (c_save_expr): Remove. > (c_common_truthvalue_conversion): Remove a call to c_save_expr. > *

Re: C PATCH to kill c_save_expr or towards delayed folding for the C FE

2017-05-15 Thread Marek Polacek
On Fri, May 12, 2017 at 08:28:38PM +, Joseph Myers wrote: > On Fri, 12 May 2017, Marek Polacek wrote: > > > In the effort of reducing early folding, we should avoid calling > > c_fully_fold > > blithely, except when needed for e.g. initializers. This is a teeny tiny > > step > > Note there

Re: C PATCH to kill c_save_expr or towards delayed folding for the C FE

2017-05-15 Thread Marek Polacek
On Fri, May 12, 2017 at 09:48:28PM +0200, Jakub Jelinek wrote: > On Fri, May 12, 2017 at 09:37:27PM +0200, Marek Polacek wrote: > > @@ -565,6 +564,25 @@ c_fully_fold_internal (tree expr, bool in_init, bool > > *maybe_const_operands, > > appropriate in any particular case. */ > >gcc_u

Re: C PATCH to kill c_save_expr or towards delayed folding for the C FE

2017-05-13 Thread Jakub Jelinek
On Fri, May 12, 2017 at 08:28:38PM +, Joseph Myers wrote: > On Fri, 12 May 2017, Marek Polacek wrote: > > > In the effort of reducing early folding, we should avoid calling > > c_fully_fold > > blithely, except when needed for e.g. initializers. This is a teeny tiny > > step > > Note there

Re: C PATCH to kill c_save_expr or towards delayed folding for the C FE

2017-05-12 Thread Joseph Myers
On Fri, 12 May 2017, Marek Polacek wrote: > In the effort of reducing early folding, we should avoid calling c_fully_fold > blithely, except when needed for e.g. initializers. This is a teeny tiny step Note there are several reasons for early folding in the C front end: at least (a) cases where

Re: C PATCH to kill c_save_expr or towards delayed folding for the C FE

2017-05-12 Thread Jakub Jelinek
On Fri, May 12, 2017 at 09:37:27PM +0200, Marek Polacek wrote: > @@ -565,6 +564,25 @@ c_fully_fold_internal (tree expr, bool in_init, bool > *maybe_const_operands, >appropriate in any particular case. */ >gcc_unreachable (); > > +case SAVE_EXPR: > + /* Make sure to fold