Re: C++ PATCHes to improve overload resolution diagnostics

2014-05-15 Thread Jason Merrill
On 05/15/2014 06:34 AM, Manuel López-Ibáñez wrote: This looks great. One minor nit: In this hunk, what is input_location pointing at and why is that better than loc? Oops, cut/paste error, thanks. Also, are there other qualifiers of 'this' besides 'const'? An object can also be 'volatile'.

Re: C++ PATCHes to improve overload resolution diagnostics

2014-05-15 Thread Manuel López-Ibáñez
On 14 May 2014 18:47, Jason Merrill wrote: > When I was working on DR 1571, I noticed that our diagnostics weren't very > helpful for reference bindings (BZ 20332/21631) so I set out to treat > lvalue/rvalue mismatches and cv-qual loss as a bad conversion rather than no > conversion. As I worked

Re: C++ PATCHes to improve overload resolution diagnostics

2014-05-15 Thread Andreas Schwab
Jason Merrill writes: > (print_z_candidate): Say "candidate:" before each candidate. * obj-c++.dg/exceptions-3.mm: Remove check for message no longer emitted. * obj-c++.dg/exceptions-5.mm: Likewise. diff --git a/gcc/testsuite/obj-c++.dg/exceptions-3.mm b/gcc/tests

Re: C++ PATCHes to improve overload resolution diagnostics

2014-05-14 Thread Jakub Jelinek
On Wed, May 14, 2014 at 12:47:11PM -0400, Jason Merrill wrote: > commit f770db5dce4328b831d3c3e50322366f3e7b927a > Author: jason > Date: Tue May 13 21:10:03 2014 + > > * call.c (print_error_for_call_failure): Say "no match" rather > than "ambiguous" if there were no strict match