Re: C++ PATCH to improve dump_decl (PR c++/71075)

2016-05-19 Thread Jason Merrill
OK. On Thu, May 19, 2016 at 4:03 PM, Marek Polacek wrote: > On Thu, May 19, 2016 at 07:55:05PM +0200, Marek Polacek wrote: >> On Thu, May 19, 2016 at 12:55:18PM -0400, Jason Merrill wrote: >> > Well, constants aren't declarations. Why are we calling dump_decl here? >> >> Eh, not sure what I was

Re: C++ PATCH to improve dump_decl (PR c++/71075)

2016-05-19 Thread Marek Polacek
On Thu, May 19, 2016 at 07:55:05PM +0200, Marek Polacek wrote: > On Thu, May 19, 2016 at 12:55:18PM -0400, Jason Merrill wrote: > > Well, constants aren't declarations. Why are we calling dump_decl here? > > Eh, not sure what I was thinking... > > We call dump_decl because unify_template_argumen

Re: C++ PATCH to improve dump_decl (PR c++/71075)

2016-05-19 Thread Marek Polacek
On Thu, May 19, 2016 at 12:55:18PM -0400, Jason Merrill wrote: > Well, constants aren't declarations. Why are we calling dump_decl here? Eh, not sure what I was thinking... We call dump_decl because unify_template_argument_mismatch has %qD: inform (input_location, " template arg

Re: C++ PATCH to improve dump_decl (PR c++/71075)

2016-05-19 Thread Jason Merrill
Well, constants aren't declarations. Why are we calling dump_decl here? Jason