Re: C++ PATCH to detect narrowing in case values (PR c++/90805)

2019-08-01 Thread Jason Merrill
On 7/17/19 4:05 PM, Marek Polacek wrote: On Wed, Jul 03, 2019 at 01:57:06PM -0400, Jason Merrill wrote: On 7/3/19 10:13 AM, Marek Polacek wrote: On Sat, Jun 22, 2019 at 11:28:36PM -0400, Jason Merrill wrote: On 6/13/19 5:03 PM, Marek Polacek wrote: Case values are converted constant expressio

Re: C++ PATCH to detect narrowing in case values (PR c++/90805)

2019-08-01 Thread Marek Polacek
Ping. On Wed, Jul 17, 2019 at 04:05:24PM -0400, Marek Polacek wrote: > On Wed, Jul 03, 2019 at 01:57:06PM -0400, Jason Merrill wrote: > > On 7/3/19 10:13 AM, Marek Polacek wrote: > > > On Sat, Jun 22, 2019 at 11:28:36PM -0400, Jason Merrill wrote: > > > > On 6/13/19 5:03 PM, Marek Polacek wrote: >

Re: C++ PATCH to detect narrowing in case values (PR c++/90805)

2019-07-17 Thread Marek Polacek
On Wed, Jul 03, 2019 at 01:57:06PM -0400, Jason Merrill wrote: > On 7/3/19 10:13 AM, Marek Polacek wrote: > > On Sat, Jun 22, 2019 at 11:28:36PM -0400, Jason Merrill wrote: > > > On 6/13/19 5:03 PM, Marek Polacek wrote: > > > > Case values are converted constant expressions, so narrowing conversion

Re: C++ PATCH to detect narrowing in case values (PR c++/90805)

2019-07-03 Thread Jason Merrill
On 7/3/19 10:13 AM, Marek Polacek wrote: On Sat, Jun 22, 2019 at 11:28:36PM -0400, Jason Merrill wrote: On 6/13/19 5:03 PM, Marek Polacek wrote: Case values are converted constant expressions, so narrowing conversion is not permitted. This patch adds detecting narrowing to case_conversion; it'

Re: C++ PATCH to detect narrowing in case values (PR c++/90805)

2019-07-03 Thread Marek Polacek
On Sat, Jun 22, 2019 at 11:28:36PM -0400, Jason Merrill wrote: > On 6/13/19 5:03 PM, Marek Polacek wrote: > > Case values are converted constant expressions, so narrowing conversion is > > not > > permitted. This patch adds detecting narrowing to case_conversion; it's a > > handy spot because we

Re: C++ PATCH to detect narrowing in case values (PR c++/90805)

2019-06-22 Thread Jason Merrill
On 6/13/19 5:03 PM, Marek Polacek wrote: Case values are converted constant expressions, so narrowing conversion is not permitted. This patch adds detecting narrowing to case_conversion; it's a handy spot because we have both the value and the (adjusted) type of the condition. Is there a reaso