Re: C++ PATCH for c++/88983 - ICE with switch in constexpr function

2019-01-31 Thread Marek Polacek
On Thu, Jan 31, 2019 at 07:11:59PM -0500, Jason Merrill wrote: > On 1/31/19 7:01 PM, Marek Polacek wrote: > > + if (*jump_target && *jump_target == orig_jump) > > You shouldn't need to check that it's non-null, since the enclosing if > established that orig_jump will be non-null. OK with that

Re: C++ PATCH for c++/88983 - ICE with switch in constexpr function

2019-01-31 Thread Jason Merrill
On 1/31/19 7:01 PM, Marek Polacek wrote: + if (*jump_target && *jump_target == orig_jump) You shouldn't need to check that it's non-null, since the enclosing if established that orig_jump will be non-null. OK with that tweak. Jason