Re: C++: fix ICE with CONST_DECLs

2013-06-12 Thread Jason Merrill
Go ahead and apply the patch; it never hurts to make the code more robust. Jason

Re: C++: fix ICE with CONST_DECLs

2013-06-12 Thread Mike Stump
On Jun 11, 2013, at 11:00 AM, Jason Merrill wrote: > On 06/11/2013 12:39 PM, Paolo Carlini wrote: >> On 06/11/2013 06:27 PM, Mike Stump wrote: >>> Here is a simple one. When processing CONST_DECLs after an error, we >>> can ICE. This avoid the ICE. > >> No testcase? > > Yep; the patch is fine,

Re: C++: fix ICE with CONST_DECLs

2013-06-11 Thread Jason Merrill
On 06/11/2013 12:39 PM, Paolo Carlini wrote: On 06/11/2013 06:27 PM, Mike Stump wrote: Here is a simple one. When processing CONST_DECLs after an error, we can ICE. This avoid the ICE. No testcase? Yep; the patch is fine, but needs a testcase. Jason

Re: C++: fix ICE with CONST_DECLs

2013-06-11 Thread Paolo Carlini
On 06/11/2013 06:27 PM, Mike Stump wrote: Here is a simple one. When processing CONST_DECLs after an error, we can ICE. This avoid the ICE. No testcase? Paolo.