Re: Add object allocators to symbol and call summaries

2019-11-06 Thread Martin Liška
On 11/5/19 6:53 PM, Jan Hubicka wrote: Found it. It turns out that ggc_prune_ovehread_list is bogus. It walks all active allocations objects and looks if they was collected accoutnig their collection and then throws away all allocations (including those not colelcted) and those gets no longer a

Re: Add object allocators to symbol and call summaries

2019-11-06 Thread Richard Biener
On Tue, Nov 5, 2019 at 6:53 PM Jan Hubicka wrote: > > > On 11/5/19 3:48 PM, Jan Hubicka wrote: > > > > > > > > > > stringpool.c:63 (alloc_node)47M: 2.3% > > > > > 0 : 0.0%0 : 0.0%0 : 0.0% 1217k > > > > > ipa-prop.c:4480 (ipa_read_edge_inf

Re: Add object allocators to symbol and call summaries

2019-11-05 Thread Jan Hubicka
> On 11/5/19 3:48 PM, Jan Hubicka wrote: > > > > > > > > stringpool.c:63 (alloc_node)47M: 2.3% > > > > 0 : 0.0%0 : 0.0%0 : 0.0% 1217k > > > > ipa-prop.c:4480 (ipa_read_edge_info)51M: 2.4% > > > > 0 : 0.0%

Re: Add object allocators to symbol and call summaries

2019-11-05 Thread Martin Liška
On 11/5/19 3:48 PM, Jan Hubicka wrote: stringpool.c:63 (alloc_node)47M: 2.3%0 : 0.0%0 : 0.0%0 : 0.0% 1217k ipa-prop.c:4480 (ipa_read_edge_info)51M: 2.4%0 : 0.0% 260k: 0.0% 404k: 0.3% 531k

Re: Add object allocators to symbol and call summaries

2019-11-05 Thread Jan Hubicka
> > > > stringpool.c:63 (alloc_node)47M: 2.3%0 > > : 0.0%0 : 0.0%0 : 0.0% 1217k > > ipa-prop.c:4480 (ipa_read_edge_info)51M: 2.4%0 > > : 0.0% 260k: 0.0% 404k: 0.3% 531k > > hash-table.h:801

Re: Add object allocators to symbol and call summaries

2019-11-05 Thread Martin Liška
On 11/5/19 12:01 PM, Jan Hubicka wrote: On 11/5/19 11:36 AM, Jan Hubicka wrote: Hi, this patch adds object allocators to manage IPA summaries. This reduces malloc overhead and fragmentation. I now get peak memory use 7.5GB instead of 10GB for firefox WPA because reduced fragmentation leads to l

Re: Add object allocators to symbol and call summaries

2019-11-05 Thread Jan Hubicka
> On 11/5/19 11:45 AM, Martin Liška wrote: > > Please rename allocator to m_allocator. > > You were faster and installed that patch. > > Thus I'm sending the adjustment. > > Martin > From 6edd5d8c4afb0451aaaf05ba857435219b31814d Mon Sep 17 00:00:00 2001 > From: Martin Liska > Date: Tue, 5 Nov

Re: Add object allocators to symbol and call summaries

2019-11-05 Thread Jan Hubicka
> On 11/5/19 11:36 AM, Jan Hubicka wrote: > > Hi, > > this patch adds object allocators to manage IPA summaries. This reduces > > malloc overhead and fragmentation. I now get peak memory use 7.5GB instead > > of 10GB for firefox WPA because reduced fragmentation leads to less COWs > > after > > f

Re: Add object allocators to symbol and call summaries

2019-11-05 Thread Martin Liška
On 11/5/19 11:45 AM, Martin Liška wrote: Please rename allocator to m_allocator. You were faster and installed that patch. Thus I'm sending the adjustment. Martin >From 6edd5d8c4afb0451aaaf05ba857435219b31814d Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Tue, 5 Nov 2019 11:50:32 +0100 S

Re: Add object allocators to symbol and call summaries

2019-11-05 Thread Martin Liška
On 11/5/19 11:36 AM, Jan Hubicka wrote: Hi, this patch adds object allocators to manage IPA summaries. This reduces malloc overhead and fragmentation. I now get peak memory use 7.5GB instead of 10GB for firefox WPA because reduced fragmentation leads to less COWs after forks. That sounds promi