On 07/27/2012 02:08 AM, Steven Bosscher wrote:
> Right. I don't like the use of this attribute on labels at all, for
> the reasons you list here. I think it would be much cleaner to add a
> branch hint on the label in the asm goto, to contain this extension
> and to also to make it clear that it's
On 07/27/2012 01:57 AM, Richard Guenther wrote:
> On Thu, Jul 26, 2012 at 11:58 PM, Richard Henderson wrote:
>> On 07/26/2012 02:41 PM, Richard Henderson wrote:
>>> This is a patch...
>>
>> ... that I should have attached. Bah.
>
> Do we need to mark the labels so we preserve them? Consider
>
Il 27/07/2012 11:40, Steven Bosscher ha scritto:
>> >
>> > As in the case where you have both an unlikely and likely jump to a
>> > basic-block. But what I understand is that rth adds a way to mark
>> > a basic-block as hot or cold, not a way to mark an edge as hot or cold
>> > (that would be what
On Fri, Jul 27, 2012 at 11:40 AM, Steven Bosscher wrote:
> On Fri, Jul 27, 2012 at 11:15 AM, Richard Guenther
> wrote:
>>> Right. I don't like the use of this attribute on labels at all, for
>>> the reasons you list here. I think it would be much cleaner to add a
>>> branch hint on the label in t
On Fri, Jul 27, 2012 at 11:15 AM, Richard Guenther
wrote:
>> Right. I don't like the use of this attribute on labels at all, for
>> the reasons you list here. I think it would be much cleaner to add a
>> branch hint on the label in the asm goto, to contain this extension
>> and to also to make it
On Fri, Jul 27, 2012 at 11:08 AM, Steven Bosscher wrote:
> On Fri, Jul 27, 2012 at 10:57 AM, Richard Guenther
> wrote:
>> On Thu, Jul 26, 2012 at 11:58 PM, Richard Henderson wrote:
>>> On 07/26/2012 02:41 PM, Richard Henderson wrote:
This is a patch...
>>>
>>> ... that I should have attache
On Fri, Jul 27, 2012 at 10:57 AM, Richard Guenther
wrote:
> On Thu, Jul 26, 2012 at 11:58 PM, Richard Henderson wrote:
>> On 07/26/2012 02:41 PM, Richard Henderson wrote:
>>> This is a patch...
>>
>> ... that I should have attached. Bah.
>
> Do we need to mark the labels so we preserve them? Co
On Thu, Jul 26, 2012 at 11:58 PM, Richard Henderson wrote:
> On 07/26/2012 02:41 PM, Richard Henderson wrote:
>> This is a patch...
>
> ... that I should have attached. Bah.
Do we need to mark the labels so we preserve them? Consider
goto foo;
foo:
bar __attribute__((cold)):
...
so bar wi
On 07/26/2012 02:41 PM, Richard Henderson wrote:
> This is a patch...
... that I should have attached. Bah.
r~
gcc/
* doc/extend.texi (attribute): Document hot/cold for labels.
* predict.c (tree_estimate_probability_bb): Handle hot/cold
attributes on user labels.
