On Mon, 2016-08-29 at 13:44 +0200, Marek Polacek wrote:
> On Mon, Aug 29, 2016 at 12:35:38PM +0200, Marek Polacek wrote:
> > On Mon, Aug 29, 2016 at 11:16:25AM +0200, Andreas Schwab wrote:
> > > On Aug 25 2016, Marek Polacek wrote:
> > >
> > > > * c-c++-common/Wlogical-not-parentheses-2.c
On Mon, Aug 29, 2016 at 12:35:38PM +0200, Marek Polacek wrote:
> On Mon, Aug 29, 2016 at 11:16:25AM +0200, Andreas Schwab wrote:
> > On Aug 25 2016, Marek Polacek wrote:
> >
> > > * c-c++-common/Wlogical-not-parentheses-2.c: New test.
> >
> > FAIL: c-c++-common/Wlogical-not-parentheses-2.c -s
On Mon, Aug 29, 2016 at 11:16:25AM +0200, Andreas Schwab wrote:
> On Aug 25 2016, Marek Polacek wrote:
>
> > * c-c++-common/Wlogical-not-parentheses-2.c: New test.
>
> FAIL: c-c++-common/Wlogical-not-parentheses-2.c -std=gnu++11 expected
> multiline pattern lines 13-17 not found: "\s*r \+
On Aug 25 2016, Marek Polacek wrote:
> * c-c++-common/Wlogical-not-parentheses-2.c: New test.
FAIL: c-c++-common/Wlogical-not-parentheses-2.c -std=gnu++11 expected
multiline pattern lines 13-17 not found: "\s*r \+= !aaa == bbb;.*\n
\^~\n r \+= !aaa == bbb;.*\n\^~~
On Thu, Aug 25, 2016 at 08:40:20AM -0400, David Malcolm wrote:
> Looks good to me, based on the above discussion. I'll try to add the
> shared fixit validation code today.
Thanks. Let me know if I can be of any help with that.
Marek
On Thu, 2016-08-25 at 10:16 +0200, Marek Polacek wrote:
> On Wed, Aug 24, 2016 at 04:03:10PM -0400, David Malcolm wrote:
> > I was thinking about maybe:
> > rich_location::add_fixit_insert_after_caret (source_location loc)
> > which would add it immediately after the *caret* location of loc -
> >
On Wed, Aug 24, 2016 at 04:03:10PM -0400, David Malcolm wrote:
> I was thinking about maybe:
> rich_location::add_fixit_insert_after_caret (source_location loc)
> which would add it immediately after the *caret* location of loc - as
> opposed to after the *finish* location of loc, or maybe just:
On Wed, 2016-08-24 at 21:50 +0200, Marek Polacek wrote:
> On Wed, Aug 24, 2016 at 02:59:43PM -0400, David Malcolm wrote:
> > On Wed, 2016-08-24 at 20:15 +0200, Marek Polacek wrote:
> > > On Wed, Aug 24, 2016 at 01:57:15PM -0400, David Malcolm wrote:
> > > > On Wed, 2016-08-24 at 19:43 +0200, Marek
On Wed, Aug 24, 2016 at 02:59:43PM -0400, David Malcolm wrote:
> On Wed, 2016-08-24 at 20:15 +0200, Marek Polacek wrote:
> > On Wed, Aug 24, 2016 at 01:57:15PM -0400, David Malcolm wrote:
> > > On Wed, 2016-08-24 at 19:43 +0200, Marek Polacek wrote:
> > > > This patch adds a fixit hint to -Wlogical
On Wed, 2016-08-24 at 20:15 +0200, Marek Polacek wrote:
> On Wed, Aug 24, 2016 at 01:57:15PM -0400, David Malcolm wrote:
> > On Wed, 2016-08-24 at 19:43 +0200, Marek Polacek wrote:
> > > This patch adds a fixit hint to -Wlogical-not-parentheses. When
> > > the
> > > LHS
> > > has a location, it pr
On Wed, Aug 24, 2016 at 01:57:15PM -0400, David Malcolm wrote:
> On Wed, 2016-08-24 at 19:43 +0200, Marek Polacek wrote:
> > This patch adds a fixit hint to -Wlogical-not-parentheses. When the
> > LHS
> > has a location, it prints:
> >
> > z.c: In function ‘int foo(int, int)’:
> > z.c:12:11: warn
On Wed, 2016-08-24 at 19:43 +0200, Marek Polacek wrote:
> This patch adds a fixit hint to -Wlogical-not-parentheses. When the
> LHS
> has a location, it prints:
>
> z.c: In function ‘int foo(int, int)’:
> z.c:12:11: warning: logical not is only applied to the left hand side
> of comparison [-Wlog
12 matches
Mail list logo
