Re: Add a constant_range_value_p function (PR 92033)

2019-10-17 Thread Richard Sandiford
Christophe Lyon writes: > On Tue, 15 Oct 2019 at 12:36, Richard Sandiford > wrote: >> >> Richard Biener writes: >> > On October 14, 2019 2:32:43 PM GMT+02:00, Richard Sandiford >> > wrote: >> >>Richard Biener writes: >> >>> On Fri, Oct 11, 2019 at 4:42 PM Richard Sandiford >> >>> wrote: >> >

Re: Add a constant_range_value_p function (PR 92033)

2019-10-17 Thread Christophe Lyon
On Tue, 15 Oct 2019 at 12:36, Richard Sandiford wrote: > > Richard Biener writes: > > On October 14, 2019 2:32:43 PM GMT+02:00, Richard Sandiford > > wrote: > >>Richard Biener writes: > >>> On Fri, Oct 11, 2019 at 4:42 PM Richard Sandiford > >>> wrote: > > The range-tracking code ha

Re: Add a constant_range_value_p function (PR 92033)

2019-10-15 Thread Richard Biener
On Tue, Oct 15, 2019 at 12:35 PM Richard Sandiford wrote: > > Richard Biener writes: > > On October 14, 2019 2:32:43 PM GMT+02:00, Richard Sandiford > > wrote: > >>Richard Biener writes: > >>> On Fri, Oct 11, 2019 at 4:42 PM Richard Sandiford > >>> wrote: > > The range-tracking code

Re: Add a constant_range_value_p function (PR 92033)

2019-10-15 Thread Richard Sandiford
Richard Biener writes: > On October 14, 2019 2:32:43 PM GMT+02:00, Richard Sandiford > wrote: >>Richard Biener writes: >>> On Fri, Oct 11, 2019 at 4:42 PM Richard Sandiford >>> wrote: The range-tracking code has a pretty hard-coded assumption that is_gimple_min_invariant is equi

Re: Add a constant_range_value_p function (PR 92033)

2019-10-14 Thread Aldy Hernandez
On 10/14/19 12:38 PM, Richard Biener wrote: On October 14, 2019 2:32:43 PM GMT+02:00, Richard Sandiford wrote: Richard Biener writes: On Fri, Oct 11, 2019 at 4:42 PM Richard Sandiford wrote: The range-tracking code has a pretty hard-coded assumption that is_gimple_min_invariant is equi

Re: Add a constant_range_value_p function (PR 92033)

2019-10-14 Thread Richard Biener
On October 14, 2019 2:32:43 PM GMT+02:00, Richard Sandiford wrote: >Richard Biener writes: >> On Fri, Oct 11, 2019 at 4:42 PM Richard Sandiford >> wrote: >>> >>> The range-tracking code has a pretty hard-coded assumption that >>> is_gimple_min_invariant is equivalent to "INTEGER_CST or invarian

Re: Add a constant_range_value_p function (PR 92033)

2019-10-14 Thread Aldy Hernandez
On 10/14/19 8:31 AM, Richard Sandiford wrote: Aldy Hernandez writes: On 10/14/19 4:30 AM, Richard Sandiford wrote: Aldy Hernandez writes: On 10/11/19 10:42 AM, Richard Sandiford wrote: The range-tracking code has a pretty hard-coded assumption that is_gimple_min_invariant is equivalent t

Re: Add a constant_range_value_p function (PR 92033)

2019-10-14 Thread Richard Sandiford
Richard Biener writes: > On Fri, Oct 11, 2019 at 4:42 PM Richard Sandiford > wrote: >> >> The range-tracking code has a pretty hard-coded assumption that >> is_gimple_min_invariant is equivalent to "INTEGER_CST or invariant >> ADDR_EXPR". It seems better to add a predicate specifically for >> th

Re: Add a constant_range_value_p function (PR 92033)

2019-10-14 Thread Richard Sandiford
Aldy Hernandez writes: > On 10/14/19 4:30 AM, Richard Sandiford wrote: >> Aldy Hernandez writes: >>> On 10/11/19 10:42 AM, Richard Sandiford wrote: The range-tracking code has a pretty hard-coded assumption that is_gimple_min_invariant is equivalent to "INTEGER_CST or invariant ADD

Re: Add a constant_range_value_p function (PR 92033)

2019-10-14 Thread Richard Biener
On Fri, Oct 11, 2019 at 4:42 PM Richard Sandiford wrote: > > The range-tracking code has a pretty hard-coded assumption that > is_gimple_min_invariant is equivalent to "INTEGER_CST or invariant > ADDR_EXPR". It seems better to add a predicate specifically for > that rather than contiually fight c

Re: Add a constant_range_value_p function (PR 92033)

2019-10-14 Thread Aldy Hernandez
On 10/14/19 4:30 AM, Richard Sandiford wrote: Aldy Hernandez writes: On 10/11/19 10:42 AM, Richard Sandiford wrote: The range-tracking code has a pretty hard-coded assumption that is_gimple_min_invariant is equivalent to "INTEGER_CST or invariant ADDR_EXPR". It seems better to add a predicate

Re: Add a constant_range_value_p function (PR 92033)

2019-10-14 Thread Richard Sandiford
Aldy Hernandez writes: > On 10/11/19 10:42 AM, Richard Sandiford wrote: >> The range-tracking code has a pretty hard-coded assumption that >> is_gimple_min_invariant is equivalent to "INTEGER_CST or invariant >> ADDR_EXPR". It seems better to add a predicate specifically for >> that rather than c

Re: Add a constant_range_value_p function (PR 92033)

2019-10-13 Thread Aldy Hernandez
On 10/11/19 10:42 AM, Richard Sandiford wrote: The range-tracking code has a pretty hard-coded assumption that is_gimple_min_invariant is equivalent to "INTEGER_CST or invariant ADDR_EXPR". It seems better to add a predicate specifically for that rather than contiually fight cases in which it ca