Re: Add -falign-all-functions

2024-01-18 Thread Richard Biener
On Wed, 17 Jan 2024, Jan Hubicka wrote: > > On Wed, 17 Jan 2024, Jan Hubicka wrote: > > > > > > > > > > I meant the new option might be named -fmin-function-alignment= > > > > rather than -falign-all-functions because of how it should > > > > override all other options. > > > > > > I was also p

Re: Add -falign-all-functions

2024-01-17 Thread Jan Hubicka
> On Wed, 17 Jan 2024, Jan Hubicka wrote: > > > > > > > I meant the new option might be named -fmin-function-alignment= > > > rather than -falign-all-functions because of how it should > > > override all other options. > > > > I was also pondering about both names. -falign-all-functions has the

Re: Add -falign-all-functions

2024-01-17 Thread Richard Biener
On Wed, 17 Jan 2024, Jan Hubicka wrote: > > > > I meant the new option might be named -fmin-function-alignment= > > rather than -falign-all-functions because of how it should > > override all other options. > > I was also pondering about both names. -falign-all-functions has the > advantage tha

Re: Add -falign-all-functions

2024-01-17 Thread Jan Hubicka
> > I meant the new option might be named -fmin-function-alignment= > rather than -falign-all-functions because of how it should > override all other options. I was also pondering about both names. -falign-all-functions has the advantage that it is similar to all the other alignment flags that a

Re: Add -falign-all-functions

2024-01-17 Thread Richard Biener
On Wed, 17 Jan 2024, Jan Hubicka wrote: > > > +falign-all-functions > > > +Common Var(flag_align_all_functions) Optimization > > > +Align the start of functions. > > > > all functions > > > > or maybe "of every function."? > > Fixed, thanks! > > > +@opindex falign-all-functions=@var{n} > > > +@

Re: Add -falign-all-functions

2024-01-17 Thread Jan Hubicka
> > +falign-all-functions > > +Common Var(flag_align_all_functions) Optimization > > +Align the start of functions. > > all functions > > or maybe "of every function."? Fixed, thanks! > > +@opindex falign-all-functions=@var{n} > > +@item -falign-all-functions > > +Specify minimal alignment for f

Re: Add -falign-all-functions

2024-01-08 Thread Richard Biener
On Thu, 4 Jan 2024, Jan Hubicka wrote: > Hi, > this patch adds new option -falign-all-functions which works like > -falign-functions, but applies to all functions including those in cold > regions. As discussed in the PR log, this is needed for atomically > patching function entries in the kernel