Re: -O2 inliner retuning 3/n: make inline hints more systematic

2019-10-04 Thread Jan Hubicka
Hi, this is fix I commit as obvious. Index: ipa-inline.c === --- ipa-inline.c(revision 276564) +++ ipa-inline.c(working copy) @@ -396,7 +396,7 @@ can_inline_edge_p (struct cgraph_edge *e static int inline_insns_singl

Re: -O2 inliner retuning 3/n: make inline hints more systematic

2019-10-04 Thread Jan Hubicka
> On Fri, 4 Oct 2019, Jan Hubicka wrote: > > > > I don't really understand the purpose of having 2 params where one is used > > > for -O2 and the other for -O3 (I didn't check -Os), instead of a single > > > param whose default value depends on -On (what we had before?). Is it so > > > that we can

Re: -O2 inliner retuning 3/n: make inline hints more systematic

2019-10-04 Thread Marc Glisse
On Fri, 4 Oct 2019, Jan Hubicka wrote: I don't really understand the purpose of having 2 params where one is used for -O2 and the other for -O3 (I didn't check -Os), instead of a single param whose default value depends on -On (what we had before?). Is it so that we can more easily mix some func

Re: -O2 inliner retuning 3/n: make inline hints more systematic

2019-10-04 Thread Jan Hubicka
> On Thu, 3 Oct 2019, Jan Hubicka wrote: > > > -/* Return inlining_insns_single limit for function N */ > > +/* Return inlining_insns_single limit for function N. If HINT is true > > + scale up the bound. */ > > > > static int > > -inline_insns_single (cgraph_node *n) > > +inline_insns_single

Re: -O2 inliner retuning 3/n: make inline hints more systematic

2019-10-04 Thread Marc Glisse
On Thu, 3 Oct 2019, Jan Hubicka wrote: -/* Return inlining_insns_single limit for function N */ +/* Return inlining_insns_single limit for function N. If HINT is true + scale up the bound. */ static int -inline_insns_single (cgraph_node *n) +inline_insns_single (cgraph_node *n, bool hint) {

Re: -O2 inliner retuning 3/n: make inline hints more systematic

2019-10-03 Thread Jan Hubicka
> On Thu, 2019-10-03 at 17:29 +0200, Jan Hubicka wrote: > > [...] > > > In this patch I however untangle it from the hinting mechanism. > > > [...] > > > Bootstrapped/regtested x86_64-linux. > > If I'm reading this right it looks like the patch is missing. Hi, patch is attached. * pa

Re: -O2 inliner retuning 3/n: make inline hints more systematic

2019-10-03 Thread David Malcolm
On Thu, 2019-10-03 at 17:29 +0200, Jan Hubicka wrote: [...] > In this patch I however untangle it from the hinting mechanism. > [...] > Bootstrapped/regtested x86_64-linux. If I'm reading this right it looks like the patch is missing. Dave