[Review for patch 1]
Joel Hutton writes:
> From e7b3017b7b5879204e9d61760a85cc84beeb4fe0 Mon Sep 17 00:00:00 2001
> From: Joel Hutton
> Date: Wed, 25 Aug 2021 14:31:15 +0100
> Subject: [PATCH 1/3] [vect-patterns] Refactor to allow internal_fn's
>
> Hi all,
>
> This refactor allows widening patte
gt;
> Subject: RE: [vect-patterns] Refactor widen_plus/widen_minus as
> internal_fns
>
> > please use #define INCLUDE_MAP before the system.h include instead.
Done.
> > Is it really necessary to build a new std::map for each optab lookup?!
> > That looks quite ugly and
> please use #define INCLUDE_MAP before the system.h include instead.
> Is it really necessary to build a new std::map for each optab lookup?!
> That looks quite ugly and inefficient. We'd usually - if necessary at all -
> build
> a auto_vec > and .sort () and .bsearch () it.
Ok, I'll rework this
On Thu, 11 Nov 2021, Joel Hutton wrote:
> Hi all,
>
> This refactor allows widening vect patterns (such as widen_plus/widen_minus)
> to be represented as
> either internal_fns or tree_codes and replaces the current
> widen_plus/widen_minus with internal_fn versions. This refactor is split into
