Re: [v4] avoid alignment of static variables affecting stack's

2015-12-14 Thread Bernd Schmidt
On 12/14/2015 03:20 PM, Richard Biener wrote: But there must be a reason statics/externals are expected and handled in all the callers (and the function). At the time this was written (git rev 60d031234), expand_one_var looked very different. It called a subroutine expand_one_static_var which

Re: [v4] avoid alignment of static variables affecting stack's

2015-12-14 Thread Richard Biener
On Mon, Dec 14, 2015 at 1:09 PM, Bernd Schmidt wrote: > On 12/14/2015 10:07 AM, Richard Biener wrote: > >> Note that we also record alignment to make sure we can spill to properly >> aligned stack slots. > > >> I don't see why we don't need to do that for used statics/externs. That >> is >> are y

Re: [v4] avoid alignment of static variables affecting stack's

2015-12-14 Thread Bernd Schmidt
On 12/14/2015 10:07 AM, Richard Biener wrote: Note that we also record alignment to make sure we can spill to properly aligned stack slots. I don't see why we don't need to do that for used statics/externs. That is are you sure we never need to spill a var of their type? Why would they be

Re: [v4] avoid alignment of static variables affecting stack's

2015-12-14 Thread Jan Beulich
>>> On 14.12.15 at 10:07, wrote: > Note that we also record alignment to make sure we can spill to properly > aligned stack slots. > > I don't see why we don't need to do that for used statics/externs. That is > are you sure we never need to spill a var of their type? No, I'm not, but note that

Re: [v4] avoid alignment of static variables affecting stack's

2015-12-14 Thread Richard Biener
On Mon, Dec 14, 2015 at 9:44 AM, Jan Beulich wrote: On 14.12.15 at 09:35, wrote: >> On Fri, Dec 11, 2015 at 2:54 PM, Bernd Schmidt wrote: >>> On 12/11/2015 02:48 PM, Jan Beulich wrote: Function (or more narrow) scope static variables (as well as others not placed on the stack

Re: [v4] avoid alignment of static variables affecting stack's

2015-12-14 Thread Jan Beulich
>>> On 14.12.15 at 09:35, wrote: > On Fri, Dec 11, 2015 at 2:54 PM, Bernd Schmidt wrote: >> On 12/11/2015 02:48 PM, Jan Beulich wrote: >>> >>> Function (or more narrow) scope static variables (as well as others not >>> placed on the stack) should also not have any effect on the stack >>> alignmen

Re: [v4] avoid alignment of static variables affecting stack's

2015-12-14 Thread Richard Biener
On Fri, Dec 11, 2015 at 2:54 PM, Bernd Schmidt wrote: > On 12/11/2015 02:48 PM, Jan Beulich wrote: >> >> Function (or more narrow) scope static variables (as well as others not >> placed on the stack) should also not have any effect on the stack >> alignment. I noticed the issue first with Linux'e

Re: [v4] avoid alignment of static variables affecting stack's

2015-12-11 Thread Bernd Schmidt
On 12/11/2015 02:48 PM, Jan Beulich wrote: Function (or more narrow) scope static variables (as well as others not placed on the stack) should also not have any effect on the stack alignment. I noticed the issue first with Linux'es dynamic_pr_debug() construct using an 8-byte aligned sub-file-sco