Re: [ubsan] Introduce pointer_sized_int_node

2013-08-28 Thread Joseph S. Myers
On Wed, 28 Aug 2013, Richard Biener wrote: > > That is not easily possible. The thing is, in the C FEs they are created > > from the C/C++ type name (for stdint purposes): > > if (INTPTR_TYPE) > > intptr_type_node = > > TREE_TYPE (identifier_global_value (c_get_ident (INTPTR_TYPE)));

Re: [ubsan] Introduce pointer_sized_int_node

2013-08-28 Thread Richard Biener
On Wed, Aug 28, 2013 at 1:10 PM, Jakub Jelinek wrote: > On Wed, Aug 28, 2013 at 12:48:41PM +0200, Richard Biener wrote: >> On Tue, Aug 27, 2013 at 2:56 PM, Marek Polacek wrote: >> > On Tue, Aug 27, 2013 at 01:48:29PM +0200, Richard Biener wrote: >> >> > + TI_POINTER_SIZED_TYPE, >> >> >> >> I'd r

Re: [ubsan] Introduce pointer_sized_int_node

2013-08-28 Thread Jakub Jelinek
On Wed, Aug 28, 2013 at 12:48:41PM +0200, Richard Biener wrote: > On Tue, Aug 27, 2013 at 2:56 PM, Marek Polacek wrote: > > On Tue, Aug 27, 2013 at 01:48:29PM +0200, Richard Biener wrote: > >> > + TI_POINTER_SIZED_TYPE, > >> > >> I'd rather see TI_UINTPTR_TYPE and TI_INTPTR_TYPE (note they might

Re: [ubsan] Introduce pointer_sized_int_node

2013-08-28 Thread Richard Biener
On Tue, Aug 27, 2013 at 2:56 PM, Marek Polacek wrote: > On Tue, Aug 27, 2013 at 01:48:29PM +0200, Richard Biener wrote: >> > + TI_POINTER_SIZED_TYPE, >> >> I'd rather see TI_UINTPTR_TYPE and TI_INTPTR_TYPE (note they might >> not be exactly of POINTER_SIZE but larger). > > We already have [u]intp

Re: [ubsan] Introduce pointer_sized_int_node

2013-08-27 Thread Marek Polacek
On Tue, Aug 27, 2013 at 01:48:29PM +0200, Richard Biener wrote: > > + TI_POINTER_SIZED_TYPE, > > I'd rather see TI_UINTPTR_TYPE and TI_INTPTR_TYPE (note they might > not be exactly of POINTER_SIZE but larger). We already have [u]intptr_type_node -- but only in c-family/, thus ubsan.c/asan.c cann

Re: [ubsan] Introduce pointer_sized_int_node

2013-08-27 Thread Richard Biener
On Mon, Aug 26, 2013 at 12:15 PM, Marek Polacek wrote: > I noticed I forgot to apply this old patch, already acked by Jason. > It introduces new pointer_sized_int_node, thus we can get rid of > uptr_type function in ubsan, and it allows us to do some clean-up > in asan.c, too. > > Tested x86_64-li