Re: [preprocessor] a few cleanups in c-family

2020-05-21 Thread Nathan Sidwell
On 5/21/20 4:02 AM, Andreas Schwab wrote: On Mai 20 2020, Nathan Sidwell wrote: I'm reverting that change. It is not ready. The first map has a different string for the main file name, and we were relying on that not equalling the later ones via pointer comparison. I must have become confuse

Re: [preprocessor] a few cleanups in c-family

2020-05-21 Thread Andreas Schwab
On Mai 20 2020, Nathan Sidwell wrote: > I'm reverting that change. It is not ready. The first map has a > different string for the main file name, and we were relying on that not > equalling the later ones via pointer comparison. > > I must have become confused over what tree I was testing. So

Re: [preprocessor] a few cleanups in c-family

2020-05-20 Thread Nathan Sidwell
On 5/20/20 2:22 PM, Nathan Sidwell wrote: Here are some small cleanups. The one bug fix is try_to_locate_new_include_insertion_point was using pointer comparison to compare strings.  This usually works, because the line table doesn't duplicate file names.  Except when reading preprocessed inp