Re: [patch testsuite gcc.dg]: Turn of ms-extensions for mingw target

2014-12-03 Thread Jason Merrill
On 11/28/2014 03:35 PM, Joseph Myers wrote: If you find you need -fno-ms-extensions as well, that's not a bug in the documentation or the testcase, it's a bug in GCC, failing to give a diagnostic for certain code for certain targets even though the standard requires it to do so. The testcase has

Re: [patch testsuite gcc.dg]: Turn of ms-extensions for mingw target

2014-11-28 Thread Joseph Myers
On Fri, 28 Nov 2014, Kai Tietz wrote: > 2014-11-28 19:10 GMT+01:00 Joseph Myers : > > On Fri, 28 Nov 2014, Kai Tietz wrote: > > > >> Some diagnostics are different and some constructs getting allowed > >> with enabled ms-extensions flag. Additionally is the pedantic-flag > >> not automatically se

Re: [patch testsuite gcc.dg]: Turn of ms-extensions for mingw target

2014-11-28 Thread Kai Tietz
2014-11-28 19:10 GMT+01:00 Joseph Myers : > On Fri, 28 Nov 2014, Kai Tietz wrote: > >> Some diagnostics are different and some constructs getting allowed >> with enabled ms-extensions flag. Additionally is the pedantic-flag >> not automatically set for *-*-mingw* targets. So for enforcing >> ISO-

Re: [patch testsuite gcc.dg]: Turn of ms-extensions for mingw target

2014-11-28 Thread Joseph Myers
On Fri, 28 Nov 2014, Kai Tietz wrote: > Some diagnostics are different and some constructs getting allowed > with enabled ms-extensions flag. Additionally is the pedantic-flag > not automatically set for *-*-mingw* targets. So for enforcing > ISO-C++ pedantic checks the *-*-mingw* targets need t

Re: [patch testsuite gcc.dg]: Turn of ms-extensions for mingw target

2014-11-28 Thread Kai Tietz
2014-11-28 18:53 GMT+01:00 Joseph Myers : > On Fri, 28 Nov 2014, Kai Tietz wrote: > >> Hi, >> >> this patch turns off ms-extensions for mingw-targets to match >> diagnostics checked in testcases. >> >> Ok for apply? > > For the tests using -std= -pedantic (or > -pedantic-errors), are you saying the

Re: [patch testsuite gcc.dg]: Turn of ms-extensions for mingw target

2014-11-28 Thread Joseph Myers
On Fri, 28 Nov 2014, Kai Tietz wrote: > Hi, > > this patch turns off ms-extensions for mingw-targets to match > diagnostics checked in testcases. > > Ok for apply? For the tests using -std= -pedantic (or -pedantic-errors), are you saying the diagnostics are *different*, or that some construct

Re: [patch testsuite gcc.dg]: Turn of ms-extensions for mingw target

2014-11-28 Thread Rainer Orth
Kai Tietz writes: > 2014-11-28 12:14 GMT+01:00 Rainer Orth : >> Hi Kai, >> >>> 2014-11-28 Kai Tietz >>> >>> * gcc.dg/anon-struct-1.c: >>> * gcc.dg/anon-struct-11.c: >>> * gcc.dg/anon-struct-2.c: >>> * gcc.dg/c11-anon-struct-2.c: >>> * gcc.dg/c11-anon-struct-3.c: >> >> those

Re: [patch testsuite gcc.dg]: Turn of ms-extensions for mingw target

2014-11-28 Thread Kai Tietz
2014-11-28 12:14 GMT+01:00 Rainer Orth : > Hi Kai, > >> 2014-11-28 Kai Tietz >> >> * gcc.dg/anon-struct-1.c: >> * gcc.dg/anon-struct-11.c: >> * gcc.dg/anon-struct-2.c: >> * gcc.dg/c11-anon-struct-2.c: >> * gcc.dg/c11-anon-struct-3.c: > > those are not exactly useful ChangeLog

Re: [patch testsuite gcc.dg]: Turn of ms-extensions for mingw target

2014-11-28 Thread Rainer Orth
Hi Kai, > 2014-11-28 Kai Tietz > > * gcc.dg/anon-struct-1.c: > * gcc.dg/anon-struct-11.c: > * gcc.dg/anon-struct-2.c: > * gcc.dg/c11-anon-struct-2.c: > * gcc.dg/c11-anon-struct-3.c: those are not exactly useful ChangeLog entries ;-) Rainer --