Re: [patch libgcc]: Adjust cygming-crtbegin code to use weak

2013-04-09 Thread Dave Korn
On 09/04/2013 11:37, Kai Tietz wrote: > Hmm, well in standard-case you are right. But well there is still a > chance that GetProcAddress returns NULL-pointer ... How would that actually happen? Removing any of those functions from libgcc or libjava would be a very serious ABI breakage; we'r

Re: [patch libgcc]: Adjust cygming-crtbegin code to use weak

2013-04-09 Thread Kai Tietz
2013/4/9 Dave Korn : > On 22/03/2013 08:44, Kai Tietz wrote: > >> 2013-03-22 Kai Tietz >> >> * config/i386/cygming-crtbegin.c (__register_frame_info): Make weak. >> (__deregister_frame_info): Likewise. > > Hi Kai, > > I read your explanation of the problem relating to x86-64 me

Re: [patch libgcc]: Adjust cygming-crtbegin code to use weak

2013-04-08 Thread Dave Korn
On 22/03/2013 08:44, Kai Tietz wrote: > 2013-03-22 Kai Tietz > > * config/i386/cygming-crtbegin.c (__register_frame_info): Make weak. > (__deregister_frame_info): Likewise. Hi Kai, I read your explanation of the problem relating to x86-64 memory models over on the Cygwin de

Re: [patch libgcc]: Adjust cygming-crtbegin code to use weak

2013-03-22 Thread Dave Korn
On 23/03/2013 00:27, Kai Tietz wrote: > 2013/3/23 Dave Korn : >> On 23/03/2013 00:08, Kai Tietz wrote: >>> 2013/3/23 Dave Korn : Also, can you explain the motivation for this change? I don't see how it's going to work right; from what I remember, we don't have weak definitions >

Re: [patch libgcc]: Adjust cygming-crtbegin code to use weak

2013-03-22 Thread Kai Tietz
2013/3/23 Dave Korn : > On 23/03/2013 00:08, Kai Tietz wrote: >> 2013/3/23 Dave Korn : > >>> Also, can you explain the motivation for this change? I don't see how >>> it's >>> going to work right; from what I remember, we don't have weak definitions in >>> PE-COFF, just weak references. How do

Re: [patch libgcc]: Adjust cygming-crtbegin code to use weak

2013-03-22 Thread Dave Korn
On 23/03/2013 00:08, Kai Tietz wrote: > 2013/3/23 Dave Korn : >> Also, can you explain the motivation for this change? I don't see how it's >> going to work right; from what I remember, we don't have weak definitions in >> PE-COFF, just weak references. How does the correct definition get chos

Re: [patch libgcc]: Adjust cygming-crtbegin code to use weak

2013-03-22 Thread Kai Tietz
2013/3/23 Dave Korn : > On 22/03/2013 08:44, Kai Tietz wrote: >> Hi, >> >> this change is actual used by cygwin and is required for upcoming x64 >> cygwin target. >> >> ChangeLog >> >> 2013-03-22 Kai Tietz >> >> * config/i386/cygming-crtbegin.c (__register_frame_info): Make weak. >>

Re: [patch libgcc]: Adjust cygming-crtbegin code to use weak

2013-03-22 Thread Dave Korn
On 22/03/2013 08:44, Kai Tietz wrote: > Hi, > > this change is actual used by cygwin and is required for upcoming x64 > cygwin target. > > ChangeLog > > 2013-03-22 Kai Tietz > > * config/i386/cygming-crtbegin.c (__register_frame_info): Make weak. > (__deregister_frame_info): Like