Re: [patch PR 51900]: Fix PE's delegitimize_address functions

2012-01-23 Thread Richard Henderson
On 01/24/2012 12:11 AM, Kai Tietz wrote: > 2012-01-23 Kai Tietz > > PR target/51900 > * config/i386/predicates.md (symbolic_operand): Allow > UNSPEC_PCREL as PIC expression for lea. > * config/i386/winnt.c (i386_pe_binds_local_p): Reworked. > * config/i386/i386.c (

Re: [patch PR 51900]: Fix PE's delegitimize_address functions

2012-01-23 Thread Richard Guenther
On Mon, Jan 23, 2012 at 2:11 PM, Kai Tietz wrote: > So revised patch with removing dwarf2out.c changes and using > default_binds_local_p_1 in  i386_pe_binds_local_p.  The dwarf2out > change isn't anymore necessary.  It seems that fix of PR/45682 fixed > this issue, too. > > > ChangeLog > > 2012-01

Re: [patch PR 51900]: Fix PE's delegitimize_address functions

2012-01-23 Thread Kai Tietz
So revised patch with removing dwarf2out.c changes and using default_binds_local_p_1 in i386_pe_binds_local_p. The dwarf2out change isn't anymore necessary. It seems that fix of PR/45682 fixed this issue, too. ChangeLog 2012-01-23 Kai Tietz PR target/51900 * config/i386/pr

Re: [patch PR 51900]: Fix PE's delegitimize_address functions

2012-01-23 Thread Kai Tietz
2012/1/23 Richard Guenther : > On Mon, Jan 23, 2012 at 12:19 PM, Kai Tietz wrote: >> 2012/1/23 Richard Guenther : >>> On Sun, Jan 22, 2012 at 8:05 PM, Kai Tietz wrote: Hello, this patch fixes reported issue in PR about common-symbols and fix behavior about -fcommon/-fno-common

Re: [patch PR 51900]: Fix PE's delegitimize_address functions

2012-01-23 Thread Kai Tietz
2012/1/23 Jakub Jelinek : > On Sun, Jan 22, 2012 at 09:24:47PM +0100, Kai Tietz wrote: >> 2012-01-22  Kai Tietz   >> >>       PR target/51900 >>       * dwarf2out.c (const_ok_for_output_1): Try to delegitimize >>       address before checking for UNSPEC. > > Why is the dwarf2out.c change needed at

Re: [patch PR 51900]: Fix PE's delegitimize_address functions

2012-01-23 Thread Richard Guenther
On Mon, Jan 23, 2012 at 12:19 PM, Kai Tietz wrote: > 2012/1/23 Richard Guenther : >> On Sun, Jan 22, 2012 at 8:05 PM, Kai Tietz wrote: >>> Hello, >>> >>> this patch fixes reported issue in PR about common-symbols and fix >>> behavior about -fcommon/-fno-common.  Additionally it adds proper >>> su

Re: [patch PR 51900]: Fix PE's delegitimize_address functions

2012-01-23 Thread Jakub Jelinek
On Sun, Jan 22, 2012 at 09:24:47PM +0100, Kai Tietz wrote: > 2012-01-22 Kai Tietz > > PR target/51900 > * dwarf2out.c (const_ok_for_output_1): Try to delegitimize > address before checking for UNSPEC. Why is the dwarf2out.c change needed at all? dwarf2out.c already calls tar

Re: [patch PR 51900]: Fix PE's delegitimize_address functions

2012-01-23 Thread Kai Tietz
2012/1/23 Richard Guenther : > On Sun, Jan 22, 2012 at 8:05 PM, Kai Tietz wrote: >> Hello, >> >> this patch fixes reported issue in PR about common-symbols and fix >> behavior about -fcommon/-fno-common.  Additionally it adds proper >> support for weakref, local-variant of weaks, and tries to hand

Re: [patch PR 51900]: Fix PE's delegitimize_address functions

2012-01-23 Thread Richard Guenther
On Sun, Jan 22, 2012 at 8:05 PM, Kai Tietz wrote: > Hello, > > this patch fixes reported issue in PR about common-symbols and fix > behavior about -fcommon/-fno-common.  Additionally it adds proper > support for weakref, local-variant of weaks, and tries to handle > resolution-file information for

Re: [patch PR 51900]: Fix PE's delegitimize_address functions

2012-01-22 Thread Kai Tietz
2012/1/22 Kai Tietz : > 2012/1/22 Jakub Jelinek : >> On Sun, Jan 22, 2012 at 08:05:12PM +0100, Kai Tietz wrote: >>> this patch fixes reported issue in PR about common-symbols and fix >>> behavior about -fcommon/-fno-common.  Additionally it adds proper >>> support for weakref, local-variant of weak

Re: [patch PR 51900]: Fix PE's delegitimize_address functions

2012-01-22 Thread Kai Tietz
2012/1/22 Jakub Jelinek : > On Sun, Jan 22, 2012 at 08:05:12PM +0100, Kai Tietz wrote: >> this patch fixes reported issue in PR about common-symbols and fix >> behavior about -fcommon/-fno-common.  Additionally it adds proper >> support for weakref, local-variant of weaks, and tries to handle >> re

Re: [patch PR 51900]: Fix PE's delegitimize_address functions

2012-01-22 Thread Jakub Jelinek
On Sun, Jan 22, 2012 at 08:05:12PM +0100, Kai Tietz wrote: > this patch fixes reported issue in PR about common-symbols and fix > behavior about -fcommon/-fno-common. Additionally it adds proper > support for weakref, local-variant of weaks, and tries to handle > resolution-file information for PE