Re: [patch] omp-low.h

2013-10-17 Thread Andrew MacLeod
On 10/17/2013 11:15 AM, Jakub Jelinek wrote: *** struct omp_for_data *** 135,141 static splay_tree all_contexts; static int taskreg_nesting_level; static int target_nesting_level; ! struct omp_region *root_omp_region; static bitmap task_shared_vars; static void

Re: [patch] omp-low.h

2013-10-17 Thread Jakub Jelinek
On Thu, Oct 17, 2013 at 11:52:21AM -0400, Andrew MacLeod wrote: > On 10/17/2013 11:15 AM, Jakub Jelinek wrote: > >>*** struct omp_for_data > >>*** 135,141 > >> static splay_tree all_contexts; > >> static int taskreg_nesting_level; > >> static int target_nesting_level; > >>! s

Re: [patch] omp-low.h

2013-10-17 Thread Jakub Jelinek
On Tue, Oct 15, 2013 at 10:46:43PM -0400, Andrew MacLeod wrote: > Bootstraps on 86_64-unknown-linux-gnu and no new regressions. OK? > > Andrew > > * tree-flow.h (struct omp_region): Move to omp-low.c Missing dot at the end of line. > Remove omp_ prototypes and variables. > *

Re: [patch] omp-low.h

2013-10-15 Thread Andrew MacLeod
On 10/11/2013 04:12 AM, Richard Biener wrote: On Fri, Oct 11, 2013 at 5:31 AM, Andrew MacLeod wrote: Missed a bit in tree-flow.h.. I mistakenly assumed omp_region belonged there :-P Anyway by moving struct omp_region into omp_low.h, along with the prototypes from tree-flow.h, gimple.h and tre

Re: [patch] omp-low.h

2013-10-11 Thread Andrew MacLeod
On 10/11/2013 04:16 AM, Jakub Jelinek wrote: On Fri, Oct 11, 2013 at 10:12:17AM +0200, Richard Biener wrote: I can spot the end of a comment containing "OpenMP Region Tree" that you didn't move - probably an oversight. Otherwise ok. Please wait for the gomp4 merge (which I'm going to commit to

Re: [patch] omp-low.h

2013-10-11 Thread Jakub Jelinek
On Fri, Oct 11, 2013 at 10:12:17AM +0200, Richard Biener wrote: > I can spot the end of a comment containing "OpenMP Region Tree" > that you didn't move - probably an oversight. > > Otherwise ok. Please wait for the gomp4 merge (which I'm going to commit today). Jakub

Re: [patch] omp-low.h

2013-10-11 Thread Richard Biener
On Fri, Oct 11, 2013 at 5:31 AM, Andrew MacLeod wrote: > Missed a bit in tree-flow.h.. I mistakenly assumed omp_region belonged > there :-P > > Anyway by moving struct omp_region into omp_low.h, along with the prototypes > from tree-flow.h, gimple.h and tree.h. Everything works great with just a