Re: [patch] moving macro definitions to defaults.h

2014-09-23 Thread Joseph S. Myers
On Tue, 23 Sep 2014, Andrew MacLeod wrote: > if() and target hooks arent exactly easy either.. Indeed - but I think the modularity goal is for the vast bulk of target macros to become hooks (not necessarily a one-to-one conversion, in some cases the right representation of the semantics may nee

Re: [patch] moving macro definitions to defaults.h

2014-09-23 Thread Andrew MacLeod
On 09/22/2014 01:02 PM, Joseph S. Myers wrote: On Mon, 22 Sep 2014, Andrew MacLeod wrote: Josephs solution was to identify these and instead put a default definition in default.h ... then change all the uses to #if instead.. ie, #if BLAH This way we can ensure that the definition has been see

Re: [patch] moving macro definitions to defaults.h

2014-09-22 Thread Joseph S. Myers
On Mon, 22 Sep 2014, David Malcolm wrote: > There appears to be a particular implicit order in which headers must be > included. I notice that e.g. tm.h has: > > #ifndef GCC_TM_H > #define GCC_TM_H > > so if we're going with this "no header file includes any other header > file" model, woul

Re: [patch] moving macro definitions to defaults.h

2014-09-22 Thread Joseph S. Myers
On Mon, 22 Sep 2014, Andrew MacLeod wrote: > Josephs solution was to identify these and instead put a default definition in > default.h ... then change all the uses to #if instead.. ie, > #if BLAH > > This way we can ensure that the definition has been seen and it will be a > compile error if no

Re: [patch] moving macro definitions to defaults.h

2014-09-22 Thread David Malcolm
On Mon, 2014-09-22 at 12:26 -0400, Andrew MacLeod wrote: > After being reminded of the tm.h issues brought up last november (here: > https://gcc.gnu.org/ml/gcc-patches/2013-11/msg01731.html ), I started > looking back into it. > > The general summary is the any header file which has a condition