Re: [patch] improve sloc assignment on bind_expr entry/exit code

2014-06-18 Thread Olivier Hainque
On Jun 18, 2014, at 15:48 , Jeff Law wrote: >> ISTM that dg-scan-asm for the expected extra .loc's would work, maybe >> restricted to some target we know produces .loc directives. >> >> Sounds appropriate ? > Yea, that should be fine. Most folks test x86-64 linux, so that's going to > get

Re: [patch] improve sloc assignment on bind_expr entry/exit code

2014-06-18 Thread Jeff Law
On 06/18/14 01:42, Olivier Hainque wrote: Hi Jeff, On Jun 17, 2014, at 22:42 , Jeff Law wrote: * tree-core.h (tree_block): Add an "end_locus" field, allowing memorization of the end of block source location. * tree.h (BLOCK_SOURCE_END_LOCATION): New accessor. *

Re: [patch] improve sloc assignment on bind_expr entry/exit code

2014-06-18 Thread Olivier Hainque
On Jun 18, 2014, at 09:42 , Olivier Hainque wrote: >> I assume y'all will add a suitable test to the Ada testsuite and propagate >> it into the GCC testsuite in due course? > ISTM that dg-scan-asm for the expected extra .loc's would work, maybe > restricted to some target we know produces .loc

Re: [patch] improve sloc assignment on bind_expr entry/exit code

2014-06-18 Thread Olivier Hainque
Hi Jeff, On Jun 17, 2014, at 22:42 , Jeff Law wrote: >> * tree-core.h (tree_block): Add an "end_locus" field, allowing >> memorization of the end of block source location. >> * tree.h (BLOCK_SOURCE_END_LOCATION): New accessor. >> * gimplify.c (gimplify_bind_expr): Propagate t

Re: [patch] improve sloc assignment on bind_expr entry/exit code

2014-06-17 Thread Jeff Law
On 06/11/14 09:02, Olivier Hainque wrote: Hello, For blocks requiring it, the gimplifier generates stack pointer save/restore operations on entry/exit, per: gimplify_bind_expr (...) if (gimplify_ctxp->save_stack) { gimple stack_restore; /* Save stack on entry and resto