Re: [patch] fix -Wformat-diag warnings in rs6000-call.c

2021-01-12 Thread Segher Boessenkool
Hi! On Wed, Jan 13, 2021 at 12:49:42AM +, Joseph Myers wrote: > On Tue, 12 Jan 2021, Segher Boessenkool wrote: > > On Sat, Jan 09, 2021 at 07:44:31PM +0100, Matthias Klose wrote: > > > These warnings, including the suggested fixes are seen on power*-linux > > > builds. > > > > > > warning: m

Re: [patch] fix -Wformat-diag warnings in rs6000-call.c

2021-01-12 Thread Joseph Myers
On Tue, 12 Jan 2021, Segher Boessenkool wrote: > On Sat, Jan 09, 2021 at 07:44:31PM +0100, Matthias Klose wrote: > > These warnings, including the suggested fixes are seen on power*-linux > > builds. > > > > warning: misspelled term 'builtin function' in format; use 'bult-in > > function' > > i

Re: [patch] fix -Wformat-diag warnings in rs6000-call.c

2021-01-12 Thread Segher Boessenkool
Hi! On Sun, Jan 10, 2021 at 02:18:24PM -0700, Martin Sebor wrote: > Symbols/identifiers should be formatted using the appropriate > directives or quoted in %< %>. We do not have a way to mark up the mathematical symbols [], but we do require those to express ranges (which is a bad idea /an sich/,

Re: [patch] fix -Wformat-diag warnings in rs6000-call.c

2021-01-12 Thread Segher Boessenkool
On Sat, Jan 09, 2021 at 07:44:31PM +0100, Matthias Klose wrote: > These warnings, including the suggested fixes are seen on power*-linux builds. > > warning: misspelled term 'builtin function' in format; use 'bult-in function' > instead [-Wformat-diag] This one is wrong. Almost all the functions

Re: [patch] fix -Wformat-diag warnings in rs6000-call.c

2021-01-11 Thread Martin Sebor via Gcc-patches
On 1/11/21 9:30 AM, Matthias Klose wrote: On 1/10/21 10:18 PM, Martin Sebor wrote: On 1/10/21 3:29 AM, Matthias Klose wrote: is the newline intended? It's followed by a debug_rtx call. To avoid the warning there shouldn't be any trailing punctuation or whitespace in the message.  The GCC quot

Re: [patch] fix -Wformat-diag warnings in rs6000-call.c

2021-01-11 Thread Matthias Klose
On 1/10/21 10:18 PM, Martin Sebor wrote: > On 1/10/21 3:29 AM, Matthias Klose wrote: >> is the newline intended? It's followed by a debug_rtx call. > > To avoid the warning there shouldn't be any trailing punctuation > or whitespace in the message.  The GCC quoting directives should > be preferred

Re: [patch] fix -Wformat-diag warnings in rs6000-call.c

2021-01-10 Thread Martin Sebor via Gcc-patches
On 1/10/21 3:29 AM, Matthias Klose wrote: On 1/9/21 11:22 PM, Jakub Jelinek wrote: On Sat, Jan 09, 2021 at 07:44:31PM +0100, Matthias Klose wrote: These warnings, including the suggested fixes are seen on power*-linux builds. warning: misspelled term 'builtin function' in format; use 'bult-in

Re: [patch] fix -Wformat-diag warnings in rs6000-call.c

2021-01-10 Thread Matthias Klose
On 1/9/21 11:22 PM, Jakub Jelinek wrote: > On Sat, Jan 09, 2021 at 07:44:31PM +0100, Matthias Klose wrote: >> These warnings, including the suggested fixes are seen on power*-linux >> builds. >> >> warning: misspelled term 'builtin function' in format; use 'bult-in function' > > Are you sure it p

Re: [patch] fix -Wformat-diag warnings in rs6000-call.c

2021-01-09 Thread Jakub Jelinek via Gcc-patches
On Sat, Jan 09, 2021 at 07:44:31PM +0100, Matthias Klose wrote: > These warnings, including the suggested fixes are seen on power*-linux builds. > > warning: misspelled term 'builtin function' in format; use 'bult-in function' Are you sure it printed bult-in ? > fatal_error (input_location,