Re: [patch] disintegrate integrate.[ch]

2012-05-29 Thread Diego Novillo
On 12-05-29 11:09 , Eric Botcazou wrote: I can only formally approve the cse.c and expmed.c hunks, so you probably need to run this by a GR. The other changes are OK. > Nice cleanup in any case! Indeed. Though you probably made my next cxx-conversion merge more difficult ;) Thanks for do

Re: [patch] disintegrate integrate.[ch]

2012-05-29 Thread Eric Botcazou
> Done, updated diff attached. You also need to adjust the ChangeLog: * expmed.c (extract_fixed_bit_field): Add ??? for seemingly outdated comment about integrate.c. > OK for trunk? I can only formally approve the cse.c and expmed.c hunks, so you probably need to run this by a

Re: [patch] disintegrate integrate.[ch]

2012-05-29 Thread Steven Bosscher
On Tue, May 29, 2012 at 11:17 AM, Eric Botcazou wrote: >> Yes, I realize that, but it looks like that code is not doing >> something because old integrate.c choked on it. Quoting that part of >> the patch: >> >> Index: expmed.c >> ===

Re: [patch] disintegrate integrate.[ch]

2012-05-29 Thread Eric Botcazou
> Yes, I realize that, but it looks like that code is not doing > something because old integrate.c choked on it. Quoting that part of > the patch: > > Index: expmed.c > === > --- expmed.c (revision 187936) > +++ expmed.c (working co

Re: [patch] disintegrate integrate.[ch]

2012-05-29 Thread Steven Bosscher
On Tue, May 29, 2012 at 8:43 AM, Eric Botcazou wrote: >> The attached patch moves the code from integrate.c to (what I hope you >> agree to be) better places: >> >> * inliner code goes to tree-inline.c >> * functions only called from dwarf2out.c are moved there. >> * allocate_initial_values is mov

Re: [patch] disintegrate integrate.[ch]

2012-05-28 Thread Eric Botcazou
> The attached patch moves the code from integrate.c to (what I hope you > agree to be) better places: > > * inliner code goes to tree-inline.c > * functions only called from dwarf2out.c are moved there. > * allocate_initial_values is moved to ira.c > * the initial-value stuff is moved to function.