Re: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread Jonathan Wakely
On 02/07/19 12:56 +0100, Jonathan Wakely wrote: On 02/07/19 11:54 +0200, Eric Botcazou wrote: Yes there are definitely still references to C++0x elsewhere in libstdc++, especially in the testsuite, but let's not add new ones. It's libgcc though, not libstdc++. And it's a bit inconvenient to h

Re: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread Jonathan Wakely
On 02/07/19 11:54 +0200, Eric Botcazou wrote: Yes there are definitely still references to C++0x elsewhere in libstdc++, especially in the testsuite, but let's not add new ones. It's libgcc though, not libstdc++. And it's a bit inconvenient to have c++0x on the one hand (gthr.h) and c++11 on t

Re: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread Eric Botcazou
> Yes there are definitely still references to C++0x elsewhere in > libstdc++, especially in the testsuite, but let's not add new ones. It's libgcc though, not libstdc++. And it's a bit inconvenient to have c++0x on the one hand (gthr.h) and c++11 on the other hand (gthr-win32-thread.c); in oth

Re: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread Jonathan Wakely
On 02/07/19 11:23 +0200, Eric Botcazou wrote: s/c++0x/c++11/ please, it hasn't been 0x for eight years now :-) I suppose I didn't invent it though, so you'll probably find more with grep... Yes there are definitely still references to C++0x elsewhere in libstdc++, especially in the testsuite,

Re: [patch] Reimplement GNU threads library on native Windows

2019-07-02 Thread Eric Botcazou
> s/c++0x/c++11/ please, it hasn't been 0x for eight years now :-) I suppose I didn't invent it though, so you'll probably find more with grep... -- Eric Botcazou

Re: [patch] Reimplement GNU threads library on native Windows

2019-06-29 Thread Jonathan Wakely
On 28/06/19 12:46 +0200, Eric Botcazou wrote: +/* The implementation strategy for the c++0x thread support is as follows. s/c++0x/c++11/ please, it hasn't been 0x for eight years now :-) I haven't reviewed the rest yet, that just jumped out at me during a quick skim of the patch.