Re: [patch] PR middle-end/43631

2013-04-15 Thread Eric Botcazou
> This didn't really help make things look prettier. The notes are > enumerated in many other places, for various purposes. I didn't like > special-casing this one INSN_NOTE oddity when there are so many others > already. So I created a note_outside_basic_block_p instead, I hope you > agree with th

Re: [patch] PR middle-end/43631

2013-04-14 Thread Steven Bosscher
On Fri, Apr 12, 2013 at 6:46 PM, Steven Bosscher wrote: >> Can we reorganize insn-notes.def so that the 3 classes are clearly separated >> (and optionally define a NOTE_INSN_CLASS macro so that we don't need to >> enumerate the notes each time)? > > That's probably a good idea, yes. This didn't re

Re: [patch] PR middle-end/43631

2013-04-12 Thread Steven Bosscher
On Fri, Apr 12, 2013 at 9:48 AM, Eric Botcazou wrote: >> The problem is actually bigger than just the var-tracking notes. The >> general problem is that there are no rules for whether or not notes >> are part of a basic block or not. Some notes never appear inside a >> basic block, some notes alwa

Re: [patch] PR middle-end/43631

2013-04-12 Thread Eric Botcazou
> The problem is actually bigger than just the var-tracking notes. The > general problem is that there are no rules for whether or not notes > are part of a basic block or not. Some notes never appear inside a > basic block, some notes always must appear inside a basic block, and > some can appear

Re: [patch] PR middle-end/43631

2013-04-09 Thread Steven Bosscher
Premature ping? Also bootstrapped&tested on ia64-unknown-linux-gnu now. On Sun, Apr 7, 2013 at 12:40 AM, Steven Bosscher wrote: > Hello, > > In this PR43631, var-tracking notes are inserted on basic block > boundaries and BB_HEAD/BB_END end up pointing to these notes. This > breaks verify_flow_inf