Re: [patch] More thorough checking in reg_fits_class_p

2012-05-24 Thread Marcus Shawcroft
On 21/05/12 15:47, Richard Earnshaw wrote: On 17/05/12 14:23, Jim MacArthur wrote: Sorry for the delay in responding to this, I had a few problems with end_hard_regno. Here's a new version of the patch, which adds to in_hard_reg_set_p the assert and a check for the hardness of end_regno. end_ha

Re: [patch] More thorough checking in reg_fits_class_p

2012-05-21 Thread Richard Earnshaw
On 17/05/12 14:23, Jim MacArthur wrote: > On 02/05/12 14:55, Richard Sandiford wrote: >> Richard Earnshaw writes: >>> On 02/05/12 14:00, Richard Sandiford wrote: Jim MacArthur writes: > New Changelog text: > > 2012-05-02 Jim MacArthur > * recog.c (reg_fits_class_p): Check bot

Re: [patch] More thorough checking in reg_fits_class_p

2012-05-18 Thread Richard Sandiford
Jim MacArthur writes: > On 02/05/12 14:55, Richard Sandiford wrote: >> Richard Earnshaw writes: >>> On 02/05/12 14:00, Richard Sandiford wrote: Jim MacArthur writes: > New Changelog text: > > 2012-05-02 Jim MacArthur > * recog.c (reg_fits_class_p): Check both regno and regno

Re: [patch] More thorough checking in reg_fits_class_p

2012-05-17 Thread Jim MacArthur
On 02/05/12 14:55, Richard Sandiford wrote: Richard Earnshaw writes: On 02/05/12 14:00, Richard Sandiford wrote: Jim MacArthur writes: New Changelog text: 2012-05-02 Jim MacArthur * recog.c (reg_fits_class_p): Check both regno and regno + offset are hard registers. Thanks. I still think t

Re: [patch] More thorough checking in reg_fits_class_p

2012-05-02 Thread Richard Sandiford
Richard Earnshaw writes: > On 02/05/12 14:00, Richard Sandiford wrote: >> Jim MacArthur writes: >>> New Changelog text: >>> >>> 2012-05-02 Jim MacArthur >>> * recog.c (reg_fits_class_p): Check both regno and regno + offset are >>> hard registers. >> >> Thanks. I still think the final: >> >>> +

Re: [patch] More thorough checking in reg_fits_class_p

2012-05-02 Thread Richard Earnshaw
On 02/05/12 14:00, Richard Sandiford wrote: > Jim MacArthur writes: >> New Changelog text: >> >> 2012-05-02 Jim MacArthur >> * recog.c (reg_fits_class_p): Check both regno and regno + offset are >> hard registers. > > Thanks. I still think the final: > >> + && HARD_REGISTER_NUM_P (end_hard

Re: [patch] More thorough checking in reg_fits_class_p

2012-05-02 Thread Richard Sandiford
Jim MacArthur writes: > New Changelog text: > > 2012-05-02 Jim MacArthur > * recog.c (reg_fits_class_p): Check both regno and regno + offset are > hard registers. Thanks. I still think the final: > + && HARD_REGISTER_NUM_P (end_hard_regno (regno + offset, mode)) check belongs in in_hard_

Re: [patch] More thorough checking in reg_fits_class_p

2012-05-02 Thread Jim MacArthur
On 30/04/12 16:19, Richard Sandiford wrote: Richard Earnshaw writes: On 30/04/12 15:39, Richard Sandiford wrote: Richard Earnshaw writes: On 30/04/12 15:07, Richard Sandiford wrote: Richard Earnshaw writes: On 26/04/12 14:20, Jim MacArthur wrote: The current code in reg_fits_class_p appe

Re: [patch] More thorough checking in reg_fits_class_p

2012-04-30 Thread Richard Earnshaw
On 30/04/12 16:36, Georg-Johann Lay wrote: > Richard Earnshaw schrieb: >> On 30/04/12 15:07, Richard Sandiford wrote: >> >>> Richard Earnshaw writes: >>> Jim MacArthur wrote: > The current code in reg_fits_class_p appears to be incorrect; since > offset may be negative, it's nec

Re: [patch] More thorough checking in reg_fits_class_p

2012-04-30 Thread Georg-Johann Lay
Richard Earnshaw schrieb: On 30/04/12 15:07, Richard Sandiford wrote: Richard Earnshaw writes: Jim MacArthur wrote: The current code in reg_fits_class_p appears to be incorrect; since offset may be negative, it's necessary to check both ends of the range otherwise an array overrun or unde

Re: [patch] More thorough checking in reg_fits_class_p

2012-04-30 Thread Richard Sandiford
Richard Earnshaw writes: > On 30/04/12 15:39, Richard Sandiford wrote: >> Richard Earnshaw writes: >>> On 30/04/12 15:07, Richard Sandiford wrote: Richard Earnshaw writes: > On 26/04/12 14:20, Jim MacArthur wrote: >> The current code in reg_fits_class_p appears to be incorrect; sinc

Re: [patch] More thorough checking in reg_fits_class_p

2012-04-30 Thread Richard Earnshaw
On 30/04/12 15:39, Richard Sandiford wrote: > Richard Earnshaw writes: >> On 30/04/12 15:07, Richard Sandiford wrote: >>> Richard Earnshaw writes: On 26/04/12 14:20, Jim MacArthur wrote: > The current code in reg_fits_class_p appears to be incorrect; since > offset may be negative,

Re: [patch] More thorough checking in reg_fits_class_p

2012-04-30 Thread Richard Sandiford
Richard Earnshaw writes: > On 30/04/12 15:07, Richard Sandiford wrote: >> Richard Earnshaw writes: >>> On 26/04/12 14:20, Jim MacArthur wrote: The current code in reg_fits_class_p appears to be incorrect; since offset may be negative, it's necessary to check both ends of the range >>>

Re: [patch] More thorough checking in reg_fits_class_p

2012-04-30 Thread Richard Earnshaw
On 30/04/12 15:07, Richard Sandiford wrote: > Richard Earnshaw writes: >> On 26/04/12 14:20, Jim MacArthur wrote: >>> The current code in reg_fits_class_p appears to be incorrect; since >>> offset may be negative, it's necessary to check both ends of the range >>> otherwise an array overrun or u

Re: [patch] More thorough checking in reg_fits_class_p

2012-04-30 Thread Richard Earnshaw
On 30/04/12 15:07, Richard Sandiford wrote: > Richard Earnshaw writes: >> On 26/04/12 14:20, Jim MacArthur wrote: >>> The current code in reg_fits_class_p appears to be incorrect; since >>> offset may be negative, it's necessary to check both ends of the range >>> otherwise an array overrun or u

Re: [patch] More thorough checking in reg_fits_class_p

2012-04-30 Thread Richard Sandiford
Richard Earnshaw writes: > On 26/04/12 14:20, Jim MacArthur wrote: >> The current code in reg_fits_class_p appears to be incorrect; since >> offset may be negative, it's necessary to check both ends of the range >> otherwise an array overrun or underrun may occur when calling >> in_hard_reg_set

Re: [patch] More thorough checking in reg_fits_class_p

2012-04-30 Thread Richard Earnshaw
On 26/04/12 14:20, Jim MacArthur wrote: > The current code in reg_fits_class_p appears to be incorrect; since > offset may be negative, it's necessary to check both ends of the range > otherwise an array overrun or underrun may occur when calling > in_hard_reg_set_p. in_hard_reg_set_p should als