Re: [patch] Implement std::make_unique

2013-05-18 Thread Jonathan Wakely
On 18 May 2013 16:36, Paolo Carlini wrote: > > Great! Don't we want it inline? This makes make_unique() inline and adds doxygen comments to unique_ptr. I don't remember why I split the unique_ptr::reset() function into two overloads back in December, so this combines them into one again, matching

Re: [patch] Implement std::make_unique

2013-05-18 Thread Jonathan Wakely
On 18 May 2013 16:57, Paolo Carlini wrote: > > > Hi again, > >>This is safe for 4.8.2 so I'll commit it there once the branch reopens. > > ... note that this will be tricky because in the branch __cplusplus doesn't > have the right value. And then at least the std::fgets tweak also needs > backpo

Re: [patch] Implement std::make_unique

2013-05-18 Thread Paolo Carlini
Hi again, >This is safe for 4.8.2 so I'll commit it there once the branch reopens. ... note that this will be tricky because in the branch __cplusplus doesn't have the right value. And then at least the std::fgets tweak also needs backporting. Paolo

Re: [patch] Implement std::make_unique

2013-05-18 Thread Paolo Carlini
Hi, Jonathan Wakely ha scritto: >* include/bits/unique_ptr.h (make_unique): Define. >* testsuite/20_util/unique_ptr/creation/single.cc: New. >* testsuite/20_util/unique_ptr/creation/array.cc: New. >* testsuite/20_util/unique_ptr/creation/array_neg.cc: New. > >Te