Re: [patch] Fix inlining glitch

2011-07-25 Thread Jan Hubicka
> > No, the problem here is deciding whether we can inline a clone. > > We look into DECL_STRUCT_FUNCTION that we can't. The real fix is one > > commented in: > > > > /* Don't inline if the callee can throw non-call exceptions but the > > caller cannot. > > FIXME: this is obviously wro

Re: [patch] Fix inlining glitch

2011-07-25 Thread Eric Botcazou
> No, the problem here is deciding whether we can inline a clone. > We look into DECL_STRUCT_FUNCTION that we can't. The real fix is one > commented in: > > /* Don't inline if the callee can throw non-call exceptions but the > caller cannot. > FIXME: this is obviously wrong for LTO whe

Re: [patch] Fix inlining glitch

2011-07-25 Thread Jan Hubicka
> On Sun, Jul 24, 2011 at 7:12 PM, Eric Botcazou wrote: > > Hi, > > > > we sometimes get messages like this in Ada: > > > > prime-mc2-other.adb: In function 'PRIME.MC2.OTHER.DO_SOMETHING': > > prime-mc2.adb:2:4: warning: inlining failed in call > > to 'PRIME.MC2.GET_INPUT_VALUE.PART': non-call exc

Re: [patch] Fix inlining glitch

2011-07-25 Thread Richard Guenther
On Sun, Jul 24, 2011 at 7:12 PM, Eric Botcazou wrote: > Hi, > > we sometimes get messages like this in Ada: > > prime-mc2-other.adb: In function 'PRIME.MC2.OTHER.DO_SOMETHING': > prime-mc2.adb:2:4: warning: inlining failed in call > to 'PRIME.MC2.GET_INPUT_VALUE.PART': non-call exception handling