Re: [patch] Fix PR target/84277

2018-03-07 Thread Richard Biener
On Wed, Mar 7, 2018 at 10:28 AM, Eric Botcazou wrote: >> For the middle-end part I'd like to see output_function_exception_table take >> an enum with two members with appropriate name - I see there wasn't >> documentation for the function but your change doesn't make semantics more >> clear, esp.

Re: [patch] Fix PR target/84277

2018-03-07 Thread Eric Botcazou
> For the middle-end part I'd like to see output_function_exception_table take > an enum with two members with appropriate name - I see there wasn't > documentation for the function but your change doesn't make semantics more > clear, esp. > > - output_one_function_exception_table (0); > - if (c

Re: [patch] Fix PR target/84277

2018-03-07 Thread Richard Biener
On Tue, Mar 6, 2018 at 6:29 PM, Eric Botcazou wrote: >> this is the breakage of SEH on 64-bit Windows introduced by defaulting to >> the -freorder-blocks-and-partition optimization. It is fixed by: >> 1. Defining ASM_DECLARE_COLD_FUNCTION_NAME & >> ASM_DECLARE_COLD_FUNCTION_SIZE, 2. Emitting a

Re: [patch] Fix PR target/84277

2018-03-06 Thread Eric Botcazou
> this is the breakage of SEH on 64-bit Windows introduced by defaulting to > the -freorder-blocks-and-partition optimization. It is fixed by: > 1. Defining ASM_DECLARE_COLD_FUNCTION_NAME & > ASM_DECLARE_COLD_FUNCTION_SIZE, 2. Emitting a nop in one more case for SEH, > 3. Splitting the excepti