Re: [patch] Enhance conditional store sinking

2011-03-24 Thread Ira Rosen
On 24 March 2011 14:40, Richard Guenther wrote: > On Thu, Mar 24, 2011 at 1:39 PM, Richard Guenther > wrote: >> On Thu, Mar 24, 2011 at 11:03 AM, H.J. Lu wrote: >>> On Tue, Mar 22, 2011 at 6:28 AM, Ira Rosen wrote: On 17 March 2011 16:48, Richard Guenther wrote: >> +  then_

Re: [patch] Enhance conditional store sinking

2011-03-24 Thread Richard Guenther
On Thu, Mar 24, 2011 at 1:39 PM, Richard Guenther wrote: > On Thu, Mar 24, 2011 at 11:03 AM, H.J. Lu wrote: >> On Tue, Mar 22, 2011 at 6:28 AM, Ira Rosen wrote: >>> On 17 March 2011 16:48, Richard Guenther wrote: >>> > +  then_datarefs = VEC_alloc (data_reference_p, heap, 1); > +  else_

Re: [patch] Enhance conditional store sinking

2011-03-24 Thread Richard Guenther
On Thu, Mar 24, 2011 at 11:03 AM, H.J. Lu wrote: > On Tue, Mar 22, 2011 at 6:28 AM, Ira Rosen wrote: >> On 17 March 2011 16:48, Richard Guenther wrote: >> +  then_datarefs = VEC_alloc (data_reference_p, heap, 1); +  else_datarefs = VEC_alloc (data_reference_p, heap, 1); +  then_dd

Re: [patch] Enhance conditional store sinking

2011-03-24 Thread H.J. Lu
On Tue, Mar 22, 2011 at 6:28 AM, Ira Rosen wrote: > On 17 March 2011 16:48, Richard Guenther wrote: > >>> +  then_datarefs = VEC_alloc (data_reference_p, heap, 1); >>> +  else_datarefs = VEC_alloc (data_reference_p, heap, 1); >>> +  then_ddrs = VEC_alloc (ddr_p, heap, 1); >>> +  else_ddrs = VEC_a

Re: [patch] Enhance conditional store sinking

2011-03-23 Thread Richard Guenther
On Tue, Mar 22, 2011 at 2:28 PM, Ira Rosen wrote: > On 17 March 2011 16:48, Richard Guenther wrote: > >>> +  then_datarefs = VEC_alloc (data_reference_p, heap, 1); >>> +  else_datarefs = VEC_alloc (data_reference_p, heap, 1); >>> +  then_ddrs = VEC_alloc (ddr_p, heap, 1); >>> +  else_ddrs = VEC_a

Re: [patch] Enhance conditional store sinking

2011-03-22 Thread Ira Rosen
On 17 March 2011 16:48, Richard Guenther wrote: >> +  then_datarefs = VEC_alloc (data_reference_p, heap, 1); >> +  else_datarefs = VEC_alloc (data_reference_p, heap, 1); >> +  then_ddrs = VEC_alloc (ddr_p, heap, 1); >> +  else_ddrs = VEC_alloc (ddr_p, heap, 1); >> +  if (!compute_data_dependences

Re: [patch] Enhance conditional store sinking

2011-03-17 Thread Richard Guenther
On Thu, Mar 17, 2011 at 3:53 PM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/17/11 08:48, Richard Guenther wrote: >> >> The gimple_uids are not initialized here, you need to make sure to >> call renumber_gimple_stmt_uids () before starting.  Note that phiopt >> incr

Re: [patch] Enhance conditional store sinking

2011-03-17 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/17/11 08:48, Richard Guenther wrote: > > The gimple_uids are not initialized here, you need to make sure to > call renumber_gimple_stmt_uids () before starting. Note that phiopt > incrementally changes the IL, so I'm not sure those uids will st

Re: [patch] Enhance conditional store sinking

2011-03-17 Thread Richard Guenther
On Wed, Mar 16, 2011 at 12:47 PM, Ira Rosen wrote: > On 16 March 2011 12:29, Richard Guenther wrote: >> On Wed, Mar 16, 2011 at 7:49 AM, Ira Rosen wrote: >>> Hi, >>> >>> This patch adds a support of conditional store sinking for cases with >>> multiple data references in then and else basic bloc

Re: [patch] Enhance conditional store sinking

2011-03-16 Thread Ira Rosen
On 16 March 2011 12:29, Richard Guenther wrote: > On Wed, Mar 16, 2011 at 7:49 AM, Ira Rosen wrote: >> Hi, >> >> This patch adds a support of conditional store sinking for cases with >> multiple data references in then and else basic blocks. The >> correctness of the transformation is checked by

Re: [patch] Enhance conditional store sinking

2011-03-16 Thread Richard Guenther
On Wed, Mar 16, 2011 at 7:49 AM, Ira Rosen wrote: > Hi, > > This patch adds a support of conditional store sinking for cases with > multiple data references in then and else basic blocks. The > correctness of the transformation is checked by verifying that there > are no read-after-write and write